Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User defined configuration options are being lost. Issue #622 #623

Closed
wants to merge 1 commit into from

Conversation

bencromwell
Copy link
Contributor

+ does not do a recursive array merge so any user defined options that are supposed to be nested underneath the "configuration" key are being lost.

`+` does not do a recursive array merge so any user defined options that are supposed to be nested underneath the "configuration" key are being lost.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 9, 2017
@dwsupplee
Copy link
Contributor

Hey @bencromwell, I'm going to close this out due to the changes incoming in #686. Thank you for the PR!

@dwsupplee dwsupplee closed this Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants