[BC Break] Implement waitUntilComplete and block while waiting for query results #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| * @type int $timeoutMs How long to wait for the query to complete, in | ||
| * milliseconds. **Defaults to** `10000` milliseconds (10 seconds). | ||
| * @type int $maxRetries The number of times to retry, checking if the | ||
| * query has completed. **Defaults to** `100`. | ||
| * @type bool $useQueryCache Whether to look for the result in the query | ||
| * cache. | ||
| * @type bool $useLegacySql If set to true the query will use |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
jdpedrie
approved these changes
Aug 21, 2017
dwsupplee
added a commit
to dwsupplee/gcloud-php
that referenced
this pull request
Oct 16, 2017
…ery results (googleapis#642) * implement waitUntilComplete on job and block waiting for queryResults * fix getIterator docblock
dwsupplee
added a commit
that referenced
this pull request
Oct 16, 2017
* Run query and wait for it to complete (#604) * Run query and wait for it to complete * Document exception on BigQueryClient::runQuery() * Update snippet test * Add support for etags on bigquery tables and datasets (#634) * [BC Break] Switch to standard SQL by default (#640) * Switch to standard SQL by default * Fix setting of useLegacySql option * Fix job config logic * Address code review * [BC Break] Implement waitUntilComplete and block while waiting for query results (#642) * implement waitUntilComplete on job and block waiting for queryResults * fix getIterator docblock * Generate BigQuery Job ID on client side with optional prefix (#643) * address code review * Introduce remaining BigQuery to GA items (#686) * introduce job configuration classes * update tests/docs and add copy/load * modify retry logic * add create on insert logic
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced by this PR:
Google\Cloud\BigQuery\Job::waitUntilComplete()has been added to help simplify the process. Closes Make an ExponentialBackoff for Jobs #89.Google\Cloud\BigQuery\QueryResultsno longer inherits reload options.Google\Cloud\BigQuery\Job::queryResults()now blocks until the query is complete.Google\Cloud\BigQuery\QueryResults::isComplete()has been marked internal, as by the timeQueryResultsare passed back to the user rows are now guaranteed to be loaded.Google\Cloud\BigQuery\QueryResultsnow implementsIteratorAggregate, allowing users to iterate directly over theQueryResults.Google\Cloud\BigQuery\BigQueryClient::runQuery()now implements jobs.insert instead of jobs.query and callsGoogle\Cloud\BigQuery\Job::queryResults()under the hood.