Add DiskInfo, disk configurations and test classes #844

mziccard · 2016-04-03T16:57:29Z

This PR adds non-functional classes for disk and disk configurations. Unit tests are also added.

coveralls · 2016-04-03T17:03:57Z

Coverage increased (+0.3%) to 83.018% when pulling d238c52 on mziccard:compute into 0e20ba9 on GoogleCloudPlatform:compute-alpha.

gcloud-java-compute/src/main/java/com/google/gcloud/compute/DiskConfiguration.java

+import java.util.Objects;
+
+/**
+ * Base class for Google Compute Engine disk configuration. A disk can be used as primary storage


ajkannan · 2016-04-04T17:52:56Z

On naming, I've momentarily confused myself thinking that DiskImageConfiguration was ImageDiskConfiguration while reviewing. I imagine that if I were coding using our library, I'd have to think a little extra to remember which one pertained to each situation just because the names are similar. I know it's difficult to think of brief class names that differentiate the two, but I wanted to hear your opinion on whether it's something worth thinking about renaming?

mziccard · 2016-04-04T18:23:18Z

@ajkannan I agree this is a little confusing however it also follows the convention <Source><Destination>Configuration. I couldn't think of a better naming because the two configuration are specular: an image used to create a disk and a disk used to create an image. Any suggestion is appreciated.

The javadoc (as well as java's static types + IDE autocompletion) should help users sorting this out.

gcloud-java-compute/src/test/java/com/google/gcloud/compute/DiskInfoTest.java

+  public void compareDiskInfo(DiskInfo expected, DiskInfo value) {
+    assertEquals(expected, value);
+    assertEquals(expected.configuration(), value.configuration());
+    assertEquals(expected.id(), value.id());


ajkannan · 2016-04-04T22:31:24Z

Done with my pass.

coveralls · 2016-04-05T10:06:56Z

Coverage increased (+0.3%) to 83.036% when pulling bf5d90b on mziccard:compute into 0e20ba9 on GoogleCloudPlatform:compute-alpha.

mziccard · 2016-04-05T15:42:16Z

Thanks for the pass @ajkannan all comments are fixed

gcloud-java-compute/src/main/java/com/google/gcloud/compute/DiskConfiguration.java

+    }
+
+    Builder(Type type, DiskConfiguration diskConfiguration) {
+      this.type = type;


coveralls · 2016-04-06T06:52:09Z

Coverage increased (+0.3%) to 83.033% when pulling 1fb53fa on mziccard:compute into 0e20ba9 on GoogleCloudPlatform:compute-alpha.

gcloud-java-compute/src/main/java/com/google/gcloud/compute/DiskInfo.java

+   * {@link ImageDiskConfiguration} to create a disk from a disk image.
+   */
+  public static Builder builder(DiskId diskId, DiskConfiguration configuration) {
+    return new BuilderImpl().diskId(diskId).configuration(configuration);


aozarov · 2016-04-07T03:16:07Z

Looks good. Few comments/question. Feel free to merge after you consider them.

coveralls · 2016-04-07T08:08:16Z

Coverage increased (+0.3%) to 83.051% when pulling 759c17a on mziccard:compute into 0e20ba9 on GoogleCloudPlatform:compute-alpha.

- Add required fields to Builder constructors - Remove redundant checkNotNull - Better document sizeGb and diskType setters

coveralls · 2016-04-07T08:16:41Z

Coverage increased (+0.3%) to 83.051% when pulling 520d7b2 on mziccard:compute into 0e20ba9 on GoogleCloudPlatform:compute-alpha.

…-ai to v2.5.2 (googleapis#844) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-document-ai](https://togithub.com/googleapis/java-document-ai) | `2.5.1` -> `2.5.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-document-ai/2.5.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-document-ai/2.5.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-document-ai/2.5.2/compatibility-slim/2.5.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-document-ai/2.5.2/confidence-slim/2.5.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-document-ai).

…plugin to v3 (#844) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-deploy-plugin](https://maven.apache.org/plugins/) | `2.8.2` -> `3.0.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/compatibility-slim/2.8.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/confidence-slim/2.8.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-recaptchaenterprise).

…ator_java versions (#844) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 472750037 Source-Link: googleapis/googleapis@88f2ea3 Source-Link: https://github.com/googleapis/googleapis-gen/commit/230a5588306aae18fe8f2a57f14d4039ad72c901 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjMwYTU1ODgzMDZhYWUxOGZlOGYyYTU3ZjE0ZDQwMzlhZDcyYzkwMSJ9

🤖 I have created a release *beep* *boop* --- ## [2.5.6](https://togithub.com/googleapis/java-recommender/compare/v2.5.5...v2.5.6) (2022-10-03) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#843](https://togithub.com/googleapis/java-recommender/issues/843)) ([89c55aa](https://togithub.com/googleapis/java-recommender/commit/89c55aaba24a32d75f58ca8b0d0e9924082906d9)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.api:api-common](https://togithub.com/googleapis/api-common-java) | `2.2.0` -> `2.2.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.api:api-common/2.2.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.api:api-common/2.2.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.api:api-common/2.2.1/compatibility-slim/2.2.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.api:api-common/2.2.1/confidence-slim/2.2.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/api-common-java</summary> ### [`v2.2.1`](https://togithub.com/googleapis/api-common-java/blob/HEAD/CHANGELOG.md#221-httpsgithubcomgoogleapisapi-common-javacomparev220v221-2022-06-09) [Compare Source](https://togithub.com/googleapis/api-common-java/compare/v2.2.0...v2.2.1) ##### Dependencies - update dependency com.google.errorprone:error_prone_annotations to v2.14.0 ([#360](https://togithub.com/googleapis/api-common-java/issues/360)) ([2bf75c6](https://togithub.com/googleapis/api-common-java/commit/2bf75c6415646df0a2dd074a75bd044d0bdc67ca)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).

🤖 I have created a release *beep* *boop* --- ## [2.8.0](googleapis/java-core@v2.7.1...v2.8.0) (2022-06-21) ### Features * add build scripts for native image testing in Java 17 ([#1440](https://github.com/googleapis/java-core/issues/1440)) ([#836](googleapis/java-core#836)) ([49e9b68](googleapis/java-core@49e9b68)) ### Dependencies * update dependency com.google.api-client:google-api-client-bom to v1.35.1 ([#843](googleapis/java-core#843)) ([d81fbf0](googleapis/java-core@d81fbf0)) * update dependency com.google.api:api-common to v2.2.1 ([#844](googleapis/java-core#844)) ([d711da9](googleapis/java-core@d711da9)) * update dependency com.google.api:gax-bom to v2.18.2 ([#849](googleapis/java-core#849)) ([d44a6d9](googleapis/java-core@d44a6d9)) * update dependency com.google.api.grpc:proto-google-common-protos to v2.9.0 ([#846](googleapis/java-core#846)) ([981b634](googleapis/java-core@981b634)) * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.4.0 ([#838](googleapis/java-core#838)) ([8b04fb4](googleapis/java-core@8b04fb4)) * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.4.1 ([#848](googleapis/java-core#848)) ([78dd4ed](googleapis/java-core@78dd4ed)) * update dependency com.google.errorprone:error_prone_annotations to v2.14.0 ([#839](googleapis/java-core#839)) ([a4b5158](googleapis/java-core@a4b5158)) * update dependency com.google.http-client:google-http-client-bom to v1.42.0 ([#845](googleapis/java-core#845)) ([24211fb](googleapis/java-core@24211fb)) * update dependency com.google.protobuf:protobuf-bom to v3.21.0 ([#840](googleapis/java-core#840)) ([93d825f](googleapis/java-core@93d825f)) * update dependency com.google.protobuf:protobuf-bom to v3.21.1 ([#841](googleapis/java-core#841)) ([7065ef0](googleapis/java-core@7065ef0)) * update dependency io.grpc:grpc-bom to v1.47.0 ([#842](googleapis/java-core#842)) ([3245109](googleapis/java-core@3245109)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Add DiskInfo, disk configurations and test classes

d238c52

mziccard added the api: compute Issues related to the Compute Engine API. label Apr 3, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 3, 2016

ajkannan reviewed Apr 4, 2016
View reviewed changes

gcloud-java-compute/src/main/java/com/google/gcloud/compute/DiskConfiguration.java

import java.util.Objects;

/**

* Base class for Google Compute Engine disk configuration. A disk can be used as primary storage

This comment was marked as spam.

Sign in to view

ajkannan reviewed Apr 4, 2016
View reviewed changes

Fix DiskInfo and configurations javadoc and test issues

094c3b3

mziccard force-pushed the compute branch from bf5d90b to 094c3b3 Compare April 5, 2016 10:58

aozarov reviewed Apr 5, 2016
View reviewed changes

gcloud-java-compute/src/main/java/com/google/gcloud/compute/DiskConfiguration.java

}

Builder(Type type, DiskConfiguration diskConfiguration) {

this.type = type;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Remove redundant parameter from configuration Builder constructor

1fb53fa

aozarov reviewed Apr 7, 2016
View reviewed changes

Minor fixes to DiskInfo and configuration

520d7b2

- Add required fields to Builder constructors - Remove redundant checkNotNull - Better document sizeGb and diskType setters

mziccard force-pushed the compute branch from 759c17a to 520d7b2 Compare April 7, 2016 08:10

mziccard merged commit 6780c0d into googleapis:compute-alpha Apr 7, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add DiskInfo, disk configurations and test classes #844

Add DiskInfo, disk configurations and test classes #844

mziccard commented Apr 3, 2016

coveralls commented Apr 3, 2016

This comment was marked as spam.

ajkannan commented Apr 4, 2016

mziccard commented Apr 4, 2016

This comment was marked as spam.

ajkannan commented Apr 4, 2016

coveralls commented Apr 5, 2016

mziccard commented Apr 5, 2016

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Apr 6, 2016

This comment was marked as spam.

aozarov commented Apr 7, 2016

coveralls commented Apr 7, 2016

coveralls commented Apr 7, 2016

Add DiskInfo, disk configurations and test classes #844

Add DiskInfo, disk configurations and test classes #844

Conversation

mziccard commented Apr 3, 2016

coveralls commented Apr 3, 2016

This comment was marked as spam.

ajkannan commented Apr 4, 2016

mziccard commented Apr 4, 2016

This comment was marked as spam.

ajkannan commented Apr 4, 2016

coveralls commented Apr 5, 2016

mziccard commented Apr 5, 2016

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Apr 6, 2016

This comment was marked as spam.

aozarov commented Apr 7, 2016

coveralls commented Apr 7, 2016

coveralls commented Apr 7, 2016