Rename id to generatedId #832

mziccard · 2016-04-01T14:46:51Z

This PR addresses #824:

Rename id to generatedId for BigQuery resources
Rename id to generatedId for Storage resources
Rename id to generatedId for Dns resources

For what concerns Dns I also renamed id in ChangeRequestInfo for consistency and because it is actually generated from the service. However, for this class there's no sources of confusion with other fields' names and id is much more used than in other resources/services so we could keep id. Do you have a preference?

coveralls · 2016-04-01T14:57:25Z

Coverage remained the same at 85.506% when pulling 2db98a4 on mziccard:rename-id into 4b1a4fd on GoogleCloudPlatform:master.

ajkannan · 2016-04-01T17:28:29Z

Three issues that break the javadoc build on Travis jdk8:

BigQuery.java:475: error: reference not found:
({@link Dataset#datasetId()}, {@link Dataset#friendlyName()} and {@link Dataset#id()})

BigQuery.java:545: error: reference not found
({@link Table#tableId()}, {@link Table#friendlyName()}, {@link Table#id()} and type, which

BigQuery.java:556: error: reference not found:
({@link Table#tableId()}, {@link Table#friendlyName()}, {@link Table#id()} and type, which

gcloud-java-dns/src/test/java/com/google/gcloud/dns/ZoneTest.java

@@ -482,7 +484,7 @@ public void testBuilder() {
    expect(dns.options()).andReturn(OPTIONS).times(8);
    replay(dns);
    assertNotEquals(zone, zone.toBuilder()
-        .id((new BigInteger(zone.id())).add(BigInteger.ONE).toString())
+        .generatedId((new BigInteger(zone.generatedId())).add(BigInteger.ONE).toString())


mziccard · 2016-04-01T17:31:55Z

@ajkannan yes I'm fixing it now, thanks

ajkannan · 2016-04-01T17:47:30Z

Question: just grepping through the database, I see two instances of id left that I'm slightly unsure about. Are they meant to be kept as id rather than generatedId?

InsertAllRequest line 84
QueryStage line 275 (which is actually a long, so perhaps not related to this change)

coveralls · 2016-04-01T17:49:15Z

Changes Unknown when pulling 8df138b on mziccard:rename-id into * on GoogleCloudPlatform:master*.

mziccard · 2016-04-01T18:14:18Z

InsertAllRequest: id here is the optional id of a row and is user-provided
QueryStage: query stage can not be created by the user and has no "identity" so I decided to keep id for brevity as it's already clear it's service-generated. If you prefer we can make it generatedId for consistency.

ajkannan · 2016-04-01T20:17:10Z

LGTM

aozarov · 2016-04-01T20:25:47Z

QueryStage: query stage can not be created by the user and has no "identity" so I decided to keep id for brevity as it's already clear it's service-generated. If you prefer we can make it generatedId for consistency.

I would have called it generatedId so our code is consistent and without the need of understanding context. id -> user defined/supplied id or reference, generated-id read-only & service-genarated id.

ajkannan · 2016-04-01T20:28:10Z

I can take care of this change

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…832) * chore(deps): update dependency com.google.cloud:libraries-bom to v26 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…ator_java versions (#832) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 472750037 Source-Link: googleapis/googleapis@88f2ea3 Source-Link: https://github.com/googleapis/googleapis-gen/commit/230a5588306aae18fe8f2a57f14d4039ad72c901 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjMwYTU1ODgzMDZhYWUxOGZlOGYyYTU3ZjE0ZDQwMzlhZDcyYzkwMSJ9

…1575) (#832) Source-Link: googleapis/synthtool@2e9ac19 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93

The module itself has been removed in #820.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [importlib-metadata](https://togithub.com/python/importlib_metadata) | `==4.8.3` -> `==4.12.0` | [![age](https://badges.renovateapi.com/packages/pypi/importlib-metadata/4.12.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/importlib-metadata/4.12.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/importlib-metadata/4.12.0/compatibility-slim/4.8.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/importlib-metadata/4.12.0/confidence-slim/4.8.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-shared-dependencies).

mziccard added the type: cleanup An internal cleanup or hygiene concern. label Apr 1, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 1, 2016

ajkannan reviewed Apr 1, 2016
View reviewed changes

mziccard added 3 commits April 1, 2016 19:31

Rename id to generatedId for BigQuery resources

3324808

Rename id to generatedId for Storage resources

d4faad3

Rename id to generatedId for Dns resources

8df138b

mziccard force-pushed the rename-id branch from 2db98a4 to 8df138b Compare April 1, 2016 17:34

ajkannan merged commit 5fea95f into googleapis:master Apr 1, 2016

mziccard mentioned this pull request Apr 7, 2016

Add DiskInfo, disk configurations and test classes #844

Merged

mziccard deleted the rename-id branch April 27, 2016 18:22

mziccard mentioned this pull request Apr 28, 2016

Better naming for resource identities and service ids #824

Closed

suztomo pushed a commit that referenced this pull request Feb 1, 2023

chore: remove native-image-support from bom (#832)

b5fbbe4

The module itself has been removed in #820.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename id to generatedId #832

Rename id to generatedId #832

mziccard commented Apr 1, 2016

coveralls commented Apr 1, 2016

ajkannan commented Apr 1, 2016

This comment was marked as spam.

mziccard commented Apr 1, 2016

ajkannan commented Apr 1, 2016

coveralls commented Apr 1, 2016

mziccard commented Apr 1, 2016

ajkannan commented Apr 1, 2016

aozarov commented Apr 1, 2016

ajkannan commented Apr 1, 2016

Rename id to generatedId #832

Rename id to generatedId #832

Conversation

mziccard commented Apr 1, 2016

coveralls commented Apr 1, 2016

ajkannan commented Apr 1, 2016

This comment was marked as spam.

mziccard commented Apr 1, 2016

ajkannan commented Apr 1, 2016

coveralls commented Apr 1, 2016

mziccard commented Apr 1, 2016

ajkannan commented Apr 1, 2016

aozarov commented Apr 1, 2016

ajkannan commented Apr 1, 2016