Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconcile NanoClock in GAX with Clock in google-cloud-java #1575

Closed
garrettjonesgoogle opened this issue Jan 27, 2017 · 1 comment
Closed

Reconcile NanoClock in GAX with Clock in google-cloud-java #1575

garrettjonesgoogle opened this issue Jan 27, 2017 · 1 comment
Assignees
@vam-google
Labels
api: core

Comments

@garrettjonesgoogle
Copy link
Member

NanoClock operates on nanoseconds and Clock operates on milliseconds, but I don't think there's a need to have two distinct classes.
vam-google added a commit to vam-google/gax-java that referenced this issue Mar 11, 2017
@vam-google
Reconcile RetrySettings & Clock
fc30507 
Reconcile RetrySettings in GAX with RetryParams in google-cloud-java
googleapis/google-cloud-java#1574
Reconcile NanoClock in GAX with Clock in google-cloud-java
googleapis/google-cloud-java#1575
@vam-google vam-google mentioned this issue Mar 11, 2017
Merged
vam-google added a commit to vam-google/google-cloud-java that referenced this issue Mar 11, 2017
@vam-google
Reconcile RetrySettings & Clock (google-cloud-java part)
2dfc761 
Reconcile RetrySettings in GAX with RetryParams in google-cloud-java
googleapis#1574
Reconcile NanoClock in GAX with Clock in google-cloud-java
googleapis#1575
@vam-google vam-google mentioned this issue Mar 11, 2017
Merged
vam-google added a commit to googleapis/gax-java that referenced this issue Mar 20, 2017
@vam-google
Reconcile RetrySettings & Clock (#235)
dfb7021 
Reconcile RetrySettings & Clock

Reconcile RetrySettings in GAX with RetryParams in google-cloud-java
googleapis/google-cloud-java#1574
Reconcile NanoClock in GAX with Clock in google-cloud-java
googleapis/google-cloud-java#1575
vam-google added a commit that referenced this issue Mar 21, 2017
@vam-google
Reconcile RetrySettings & Clock (google-cloud-java part) (#1738)
95b70eb 
Reconcile RetrySettings & Clock (google-cloud-java part)

Reconcile RetrySettings in GAX with RetryParams in google-cloud-java
#1574
Reconcile NanoClock in GAX with Clock in google-cloud-java
#1575
@vam-google
Copy link
Contributor

Merged to upstream. Closing.

chingor13 pushed a commit to googleapis/java-core that referenced this issue Aug 27, 2019
@vam-google
Reconcile RetrySettings & Clock (google-cloud-java part) (#1738)
e61808a 
Reconcile RetrySettings & Clock (google-cloud-java part)

Reconcile RetrySettings in GAX with RetryParams in google-cloud-java
googleapis/google-cloud-java#1574
Reconcile NanoClock in GAX with Clock in google-cloud-java
googleapis/google-cloud-java#1575
chingor13 pushed a commit to googleapis/java-core that referenced this issue Sep 6, 2019
@vam-google
Reconcile RetrySettings & Clock (google-cloud-java part) (#1738)
76fee5b 
Reconcile RetrySettings & Clock (google-cloud-java part)

Reconcile RetrySettings in GAX with RetryParams in google-cloud-java
googleapis/google-cloud-java#1574
Reconcile NanoClock in GAX with Clock in google-cloud-java
googleapis/google-cloud-java#1575
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
86942f9 
…1575) (#460)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
09498d0 
…1575) (#975)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
815cace 
…1575) (#889)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
40cac35 
…1575) (#713)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
0303378 
…1575) (#710)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
7944165 
…1575) (#1075)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
cb9a752 
…1575) (#379)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
8eee121 
…1575) (#939)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
3a6830f 
…1575) (#886)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
5c8d9c1 
…1575) (#89)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
c53ad86 
…1575) (#235)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
ba7f0d8 
…1575) (#76)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
174e2b2 
…1575) (#215)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
3f60878 
…1575) (#744)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
b221637 
…1575) (#264)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
b7d267e 
…1575) (#98)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
c8f67e8 
…1575) (#725)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
e0482ce 
…1575) (#290)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
b13c7d8 
…1575) (#925)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
2dc427e 
…1575) (#11)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
aa706dc 
…1575) (#12)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
d4a5cc2 
…1575) (#479)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
cef8606 
…1575) (#982)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
375d0a5 
…1575) (#493)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
5869d54 
…1575) (#10)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
fcbf9a4 
…1575) (#703)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
0ce1c58 
…1575) (#212)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
ddd1b32 
…1575) (#294)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
7389abe 
…1575) (#690)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
75f71e5 
…1575) (#753)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
fae029b 
…1575) (#56)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
c7404f6 
…1575) (#700)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
41d2182 
…1575) (#859)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
52ab68f 
…1575) (#688)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
99067dc 
…1575) (#14)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
74df03d 
…1575) (#8)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
0692a06 
…1575) (#784)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
suztomo pushed a commit that referenced this issue Feb 1, 2023
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
014bafc 
…1575) (#914)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
suztomo pushed a commit that referenced this issue Feb 1, 2023
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
ef3cdc5 
…1575) (#795)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
suztomo pushed a commit that referenced this issue Feb 1, 2023
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
ebfe1c8 
…1575) (#421)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vam-google vam-google

Labels
api: core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danoscarmike @garrettjonesgoogle @vam-google