Remove redundant parameter from configuration Builder constructor

googleapis · Apr 6, 2016 · 1fb53fa · 1fb53fa
1 parent 094c3b3
commit 1fb53fa
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 9 deletions.
diff --git a/gcloud-java-compute/src/main/java/com/google/gcloud/compute/DiskConfiguration.java b/gcloud-java-compute/src/main/java/com/google/gcloud/compute/DiskConfiguration.java
@@ -76,8 +76,8 @@ public abstract static class Builder<T extends DiskConfiguration, B extends Buil
       this.type = type;
     }
 
-    Builder(Type type, DiskConfiguration diskConfiguration) {
-      this.type = type;
+    Builder(DiskConfiguration diskConfiguration) {
+      this.type = diskConfiguration.type;
       this.sizeGb = diskConfiguration.sizeGb;
       this.diskType = diskConfiguration.diskType;
     }

diff --git a/gcloud-java-compute/src/main/java/com/google/gcloud/compute/DiskImageConfiguration.java b/gcloud-java-compute/src/main/java/com/google/gcloud/compute/DiskImageConfiguration.java
@@ -48,7 +48,7 @@ private Builder() {
     }
 
     private Builder(DiskImageConfiguration imageConfiguration) {
-      super(Type.DISK, imageConfiguration);
+      super(imageConfiguration);
       this.sourceDisk = imageConfiguration.sourceDisk;
       this.sourceDiskId = imageConfiguration.sourceDiskId;
     }

diff --git a/gcloud-java-compute/src/main/java/com/google/gcloud/compute/ImageConfiguration.java b/gcloud-java-compute/src/main/java/com/google/gcloud/compute/ImageConfiguration.java
@@ -73,8 +73,8 @@ public abstract static class Builder<T extends ImageConfiguration, B extends Bui
       this.type = type;
     }
 
-    Builder(Type type, ImageConfiguration imageConfiguration) {
-      this.type = type;
+    Builder(ImageConfiguration imageConfiguration) {
+      this.type = imageConfiguration.type;
       this.sourceType = imageConfiguration.sourceType;
       this.archiveSizeBytes = imageConfiguration.archiveSizeBytes;
     }

diff --git a/gcloud-java-compute/src/main/java/com/google/gcloud/compute/ImageDiskConfiguration.java b/gcloud-java-compute/src/main/java/com/google/gcloud/compute/ImageDiskConfiguration.java
@@ -49,7 +49,7 @@ private Builder() {
     }
 
     private Builder(ImageDiskConfiguration configuration) {
-      super(Type.IMAGE, configuration);
+      super(configuration);
       this.sourceImage = configuration.sourceImage;
       this.sourceImageId = configuration.sourceImageId;
     }

diff --git a/gcloud-java-compute/src/main/java/com/google/gcloud/compute/SnapshotDiskConfiguration.java b/gcloud-java-compute/src/main/java/com/google/gcloud/compute/SnapshotDiskConfiguration.java
@@ -50,7 +50,7 @@ private Builder() {
     }
 
     private Builder(SnapshotDiskConfiguration configuration) {
-      super(Type.SNAPSHOT, configuration);
+      super(configuration);
       this.sourceSnapshot = configuration.sourceSnapshot;
       this.sourceSnapshotId = configuration.sourceSnapshotId;
     }

diff --git a/gcloud-java-compute/src/main/java/com/google/gcloud/compute/StandardDiskConfiguration.java b/gcloud-java-compute/src/main/java/com/google/gcloud/compute/StandardDiskConfiguration.java
@@ -41,7 +41,7 @@ private Builder() {
     }
 
     private Builder(StandardDiskConfiguration configuration) {
-      super(Type.STANDARD, configuration);
+      super(configuration);
     }
 
     private Builder(Disk diskPb) {

diff --git a/gcloud-java-compute/src/main/java/com/google/gcloud/compute/StorageImageConfiguration.java b/gcloud-java-compute/src/main/java/com/google/gcloud/compute/StorageImageConfiguration.java
@@ -58,7 +58,7 @@ private Builder() {
     }
 
     private Builder(StorageImageConfiguration imageConfiguration) {
-      super(Type.STORAGE, imageConfiguration);
+      super(imageConfiguration);
       this.containerType = imageConfiguration.containerType;
       this.sha1 = imageConfiguration.sha1;
       this.source = imageConfiguration.source;