fix: process messages from all files

[alexander-fenster]

This change makes Proto class know about all the messages (including those from another files), not only about messages from the current file. This was triggered by Spanner backup API, specifically ListBackups RPC (the request and response messages for this call were defined in a different file and it broke the auto-pagination logic), but, as it turns out, it also adds some more resource helpers that were previously missing :)

I did not add new baseline tests, but covered the allMessages logic in a unit test instead.

[xiaozhenliu-gg5]

I have a general question, we don't touch any resource logic here, so why more resource helpers are added? (since resourceDatabase is constructed in API level)

[alexander-fenster]

Re: general question - I don't know! :) I assume it's probably because when we generate resources, we do

for (const property of Object.keys(messages)) {

and we have more messages to consider now (so more messages will be considered used).

[xiaozhenliu-gg5]

Thank you for doing this!

I think you are right, in augmentService we have this iteration to get resources for the service
for (const property of Object.keys(messages)) But now messages refer to allMessages, one concern is that I guess we will generate same all resources for all services, like monitoring Api we have 30 resource helpers in client files. But I think it's fine if we are good with generating more resource helpers.

[alexander-fenster]

Oh, I see the concern. Well yes, this might be a problem. Do you think we also need to pass this file's messages for resource generation?

[alexander-fenster]

@xiaozhenliu-gg5 I refactored the code a little bit, now passing both allMessages and localMessages. Also, since some functions accept several parameters with same types (two MessageMap and two ResourceDatabase, this became pretty scary so I refactored it into passing objects as parameters (makes it harder to make a mistake passing wrong thing). Please review once more :) No baseline changes now, and the new allMessages functionality is covered by a unit test.

[xiaozhenliu-gg5]

LGTM! thanks!