-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't insert underscores for retry codes #172
Merged
alexander-fenster
merged 2 commits into
googleapis:master
from
schmidt-sebastian:mrschmidt/snakecase
Dec 14, 2019
Merged
fix: don't insert underscores for retry codes #172
alexander-fenster
merged 2 commits into
googleapis:master
from
schmidt-sebastian:mrschmidt/snakecase
Dec 14, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Dec 14, 2019
alexander-fenster
approved these changes
Dec 14, 2019
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
May 21, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## 0.99.0 (2020-05-21) ### ⚠ BREAKING CHANGES * bazel build (#442) * drop Node 8 & update Typescript to 3.8.x (#339) * resource generation logic fix (#225) * generate all api resources and resource definition which is referenced. (#222) ### Features * a script to update baselines ([#100](https://www.github.com/googleapis/gapic-generator-typescript/issues/100)) ([07cabdc](https://www.github.com/googleapis/gapic-generator-typescript/commit/07cabdc993b734459699ecddf08f0d05e5b81336)) * add asset API to baseline test ([#454](https://www.github.com/googleapis/gapic-generator-typescript/issues/454)) ([1f76171](https://www.github.com/googleapis/gapic-generator-typescript/commit/1f761719801d28795963f6b393fb7ce6f5b7f920)) * add close() API ([#126](https://www.github.com/googleapis/gapic-generator-typescript/issues/126)) ([9588ddf](https://www.github.com/googleapis/gapic-generator-typescript/commit/9588ddfd270e9ced8f3350ed717d1288bee41560)) * add comments for page stream method ([#116](https://www.github.com/googleapis/gapic-generator-typescript/issues/116)) ([c6a185a](https://www.github.com/googleapis/gapic-generator-typescript/commit/c6a185a7dc15f5aad42ce5d6be6b758f21220e60)) * add docker test script ([#103](https://www.github.com/googleapis/gapic-generator-typescript/issues/103)) ([79deccc](https://www.github.com/googleapis/gapic-generator-typescript/commit/79deccc2f453033c7f42516a309825a64e79653f)) * add jsdoc comment for parameters ([#94](https://www.github.com/googleapis/gapic-generator-typescript/issues/94)) ([48011c6](https://www.github.com/googleapis/gapic-generator-typescript/commit/48011c680962e25794d8e22f50e8006fd883c29b)) * add proto list template ([#24](https://www.github.com/googleapis/gapic-generator-typescript/issues/24)) ([b47fda9](https://www.github.com/googleapis/gapic-generator-typescript/commit/b47fda99821d1bd8b7a6aa50c868470e23852f0c)) * add starter script for micro-gen ([#49](https://www.github.com/googleapis/gapic-generator-typescript/issues/49)) ([9bad51d](https://www.github.com/googleapis/gapic-generator-typescript/commit/9bad51d631d65a4ab4ab41b3f6a9ca0260e6b5dc)) * allow constructors with no parameters ([#65](https://www.github.com/googleapis/gapic-generator-typescript/issues/65)) ([8ba98a0](https://www.github.com/googleapis/gapic-generator-typescript/commit/8ba98a0e64b34431e249234e9ab0550045021daf)) * decode LRO metadata & response for users ([#420](https://www.github.com/googleapis/gapic-generator-typescript/issues/420)) ([1fb42f2](https://www.github.com/googleapis/gapic-generator-typescript/commit/1fb42f2a49e0ce701a20dd855f4ad4a0e3e7864c)) * deferred initialization ([#317](https://www.github.com/googleapis/gapic-generator-typescript/issues/317)) ([d93eea4](https://www.github.com/googleapis/gapic-generator-typescript/commit/d93eea48a906069d46b0b7b62afe47f4c52e1a7c)) * do not mention overriding Promise ([#318](https://www.github.com/googleapis/gapic-generator-typescript/issues/318)) ([76e9d37](https://www.github.com/googleapis/gapic-generator-typescript/commit/76e9d3720026fc84168f89a50fdd890c6d183c54)) * docker interface ([#77](https://www.github.com/googleapis/gapic-generator-typescript/issues/77)) ([193a899](https://www.github.com/googleapis/gapic-generator-typescript/commit/193a899319920db9fa2c88bcd9fa505ae63fde2f)) * drop Node 8 & update Typescript to 3.8.x ([#339](https://www.github.com/googleapis/gapic-generator-typescript/issues/339)) ([1a928a3](https://www.github.com/googleapis/gapic-generator-typescript/commit/1a928a3d7bb7a0056e876fe6d70b140d5cb34876)) * enable --iam-service options for including IAM methods ([#375](https://www.github.com/googleapis/gapic-generator-typescript/issues/375)) ([5a105ee](https://www.github.com/googleapis/gapic-generator-typescript/commit/5a105ee0198e569d46cf763e44d87fab1b336820)) * enable release-please bot ([#472](https://www.github.com/googleapis/gapic-generator-typescript/issues/472)) ([5b8b6f9](https://www.github.com/googleapis/gapic-generator-typescript/commit/5b8b6f9392acae7c4377a0961ecafba2b8348b99)) * export bazel build rules for googleapis ([#511](https://www.github.com/googleapis/gapic-generator-typescript/issues/511)) ([11f6f49](https://www.github.com/googleapis/gapic-generator-typescript/commit/11f6f491a4ecc9dcd1114281c2f0b128d76dd918)) * export protos in src/index.ts ([#296](https://www.github.com/googleapis/gapic-generator-typescript/issues/296)) ([e6ac1b5](https://www.github.com/googleapis/gapic-generator-typescript/commit/e6ac1b569097ffebc486730db339f53a6c3a9fcc)) * expose service stub as public member ([#167](https://www.github.com/googleapis/gapic-generator-typescript/issues/167)) ([f926473](https://www.github.com/googleapis/gapic-generator-typescript/commit/f926473c2364c7bcf7ba0b1ae99c8947d04e8147)) * fail for misconfigured service and longrunning method ([#456](https://www.github.com/googleapis/gapic-generator-typescript/issues/456)) ([cfaef54](https://www.github.com/googleapis/gapic-generator-typescript/commit/cfaef54baba7bcb8058fe54425555cfb882328ee)) * generate .jsdoc.js for client library ([#128](https://www.github.com/googleapis/gapic-generator-typescript/issues/128)) ([6d23093](https://www.github.com/googleapis/gapic-generator-typescript/commit/6d230931646802d912ce649a5dd0525e2064e9bb)) * generate all api resources and resource definition which is referenced. ([#222](https://www.github.com/googleapis/gapic-generator-typescript/issues/222)) ([1e00a2d](https://www.github.com/googleapis/gapic-generator-typescript/commit/1e00a2ddca32dd81df0f6baba23c209933654198)) * generate JSON service config based on gRPC service config ([#73](https://www.github.com/googleapis/gapic-generator-typescript/issues/73)) ([fd114d3](https://www.github.com/googleapis/gapic-generator-typescript/commit/fd114d363b7a9e7539da380a50edcd2d15776673)) * generate webpack config js ([#131](https://www.github.com/googleapis/gapic-generator-typescript/issues/131)) ([2171b6f](https://www.github.com/googleapis/gapic-generator-typescript/commit/2171b6f1898823d052b2aa96260a0bbf562fe824)) * let user pass package name to the generator ([#148](https://www.github.com/googleapis/gapic-generator-typescript/issues/148)) ([5583523](https://www.github.com/googleapis/gapic-generator-typescript/commit/55835232be72648b299345ff4215d81e70d32035)) * pack and install test ([#121](https://www.github.com/googleapis/gapic-generator-typescript/issues/121)) ([b910471](https://www.github.com/googleapis/gapic-generator-typescript/commit/b9104716a1af137e748da2c43f5f835b2fedf72a)) * parse child_type resource ([#176](https://www.github.com/googleapis/gapic-generator-typescript/issues/176)) ([ef7482f](https://www.github.com/googleapis/gapic-generator-typescript/commit/ef7482f77d0491a28beb4be28b6ac837afd010a4)) * replace system test with pack-n-play ([#132](https://www.github.com/googleapis/gapic-generator-typescript/issues/132)) ([2e4bcb5](https://www.github.com/googleapis/gapic-generator-typescript/commit/2e4bcb5a06de33eaeea97083ff6f0233018ee478)) * resource generation logic fix ([#225](https://www.github.com/googleapis/gapic-generator-typescript/issues/225)) ([ab80230](https://www.github.com/googleapis/gapic-generator-typescript/commit/ab80230c89f24f05039d4ccc77ef151a5a5e459d)) * respect common resources ([#81](https://www.github.com/googleapis/gapic-generator-typescript/issues/81)) ([ef6036c](https://www.github.com/googleapis/gapic-generator-typescript/commit/ef6036c1032cede9abe1e9ac6f8b6ecc1ca20347)) * respect resource annotation ([#71](https://www.github.com/googleapis/gapic-generator-typescript/issues/71)) ([c6de4c5](https://www.github.com/googleapis/gapic-generator-typescript/commit/c6de4c50dd8383cbb18181e73905051937c6817d)) * set main service name ([#183](https://www.github.com/googleapis/gapic-generator-typescript/issues/183)) ([be27d86](https://www.github.com/googleapis/gapic-generator-typescript/commit/be27d86c3aa9a37f512bb99c9baf67f490621a04)) * show latest commit when running docker image ([#154](https://www.github.com/googleapis/gapic-generator-typescript/issues/154)) ([654b3aa](https://www.github.com/googleapis/gapic-generator-typescript/commit/654b3aa58d7ce59c799a89c0fd122ea998f57f0d)) * sort package-json for generator to avoid noise in API conversion ([#352](https://www.github.com/googleapis/gapic-generator-typescript/issues/352)) ([383ad4b](https://www.github.com/googleapis/gapic-generator-typescript/commit/383ad4b9448f281a4015698cd6b9030ba39fea60)) * support additional_bindings in google.api.http option ([#223](https://www.github.com/googleapis/gapic-generator-typescript/issues/223)) ([245deef](https://www.github.com/googleapis/gapic-generator-typescript/commit/245deef83e34d72bb16719ce8b5b1ec5653c5379)) * support async iterator for paging method ([#199](https://www.github.com/googleapis/gapic-generator-typescript/issues/199)) ([4d41ad3](https://www.github.com/googleapis/gapic-generator-typescript/commit/4d41ad3a18d9b81b9394e816d69504aef4bbb20c)), closes [#208](https://www.github.com/googleapis/gapic-generator-typescript/issues/208) * support bundle request ([#330](https://www.github.com/googleapis/gapic-generator-typescript/issues/330)) ([264fb7b](https://www.github.com/googleapis/gapic-generator-typescript/commit/264fb7bb17504ad22622634bef475da3fed918af)) * support file-level resource annotations ([#169](https://www.github.com/googleapis/gapic-generator-typescript/issues/169)) ([e71cb5c](https://www.github.com/googleapis/gapic-generator-typescript/commit/e71cb5cb5185850a69bb8e5303db2d56b6e73e40)) * support google.api.http annotation ([#83](https://www.github.com/googleapis/gapic-generator-typescript/issues/83)) ([712516f](https://www.github.com/googleapis/gapic-generator-typescript/commit/712516fbea18cd1bdc7ad5579d4931a225c7f6c2)) * support LRO methods ([#27](https://www.github.com/googleapis/gapic-generator-typescript/issues/27)) ([65994f9](https://www.github.com/googleapis/gapic-generator-typescript/commit/65994f9a1d86dae0c0eec0fd454835b9ad194dd5)) * support multi-pattern resources ([#213](https://www.github.com/googleapis/gapic-generator-typescript/issues/213)) ([c70d1d4](https://www.github.com/googleapis/gapic-generator-typescript/commit/c70d1d4f95a0314030bbd6c07d518d7d8d7a6175)) * support non-slash resource for Ads ([#461](https://www.github.com/googleapis/gapic-generator-typescript/issues/461)) ([68982db](https://www.github.com/googleapis/gapic-generator-typescript/commit/68982dba00899a5ea58db39117a2bb3257415cfb)) * support pagestreaming method ([#113](https://www.github.com/googleapis/gapic-generator-typescript/issues/113)) ([ba9891b](https://www.github.com/googleapis/gapic-generator-typescript/commit/ba9891be912fe1aa31040b1ebb86e204964938c7)) * support paging method ([#28](https://www.github.com/googleapis/gapic-generator-typescript/issues/28)) ([b445cdc](https://www.github.com/googleapis/gapic-generator-typescript/commit/b445cdc29ebc66b7bc9de5a0d5b3a501e8962841)) * support proto packages in different namespace ([#219](https://www.github.com/googleapis/gapic-generator-typescript/issues/219)) ([90177c6](https://www.github.com/googleapis/gapic-generator-typescript/commit/90177c69cb7ab0c399c6f12fb6a2d63319a9c474)) * support streaming method ([eb563e9](https://www.github.com/googleapis/gapic-generator-typescript/commit/eb563e90a8097c0af05b1197c3d47a77fc1c0f08)) * switch to .mochar.js ([#395](https://www.github.com/googleapis/gapic-generator-typescript/issues/395)) ([94de62f](https://www.github.com/googleapis/gapic-generator-typescript/commit/94de62f83aa043792dfd2378808f762848af98b0)) * TypeScript microgenerator - initial pull request ([6f91152](https://www.github.com/googleapis/gapic-generator-typescript/commit/6f91152a24dba83a26a777122f5c74be8096e6a7)) * use common interface from gax ([#122](https://www.github.com/googleapis/gapic-generator-typescript/issues/122)) ([39e285c](https://www.github.com/googleapis/gapic-generator-typescript/commit/39e285c08f851ff02fc23f951957267620ebde91)) * use explicit mocha imports ([#187](https://www.github.com/googleapis/gapic-generator-typescript/issues/187)) ([5d8608f](https://www.github.com/googleapis/gapic-generator-typescript/commit/5d8608f6149db7c71bfc82142b880f39953ac6b8)) * use protos from google-gax ([#15](https://www.github.com/googleapis/gapic-generator-typescript/issues/15)) ([4076f85](https://www.github.com/googleapis/gapic-generator-typescript/commit/4076f858fbdf905c4a08aaa8c5fef32a5662464a)) * **deps:** update gts dependency for generate client library ([#343](https://www.github.com/googleapis/gapic-generator-typescript/issues/343)) ([a63f235](https://www.github.com/googleapis/gapic-generator-typescript/commit/a63f235296fb92d0c73c1df8a707765a779addcf)) * **deps:** update gts to v2 ([#340](https://www.github.com/googleapis/gapic-generator-typescript/issues/340)) ([26933fe](https://www.github.com/googleapis/gapic-generator-typescript/commit/26933fe0cbcff858af0760e3c102faacad80e11d)) ### Bug Fixes * **deps:** bump google-gax to 1.7.5 ([#63](https://www.github.com/googleapis/gapic-generator-typescript/issues/63)) ([995deac](https://www.github.com/googleapis/gapic-generator-typescript/commit/995deacec358a104d31f4f278ba85fe01a0417cc)) * **deps:** update dependency fs-extra to v9 ([#338](https://www.github.com/googleapis/gapic-generator-typescript/issues/338)) ([9aaaa6f](https://www.github.com/googleapis/gapic-generator-typescript/commit/9aaaa6f4539ebb727c160231fc51ccb7cff99be3)) * sort path templates, ignore useless templates ([#231](https://www.github.com/googleapis/gapic-generator-typescript/issues/231)) ([401e3b5](https://www.github.com/googleapis/gapic-generator-typescript/commit/401e3b56771a773538aa78e7a4996b75a1aad185)) * **deps:** update dependency get-stdin to v7 ([#23](https://www.github.com/googleapis/gapic-generator-typescript/issues/23)) ([568f868](https://www.github.com/googleapis/gapic-generator-typescript/commit/568f8684c3490efe822afa55c65694178bcba4ac)) * add api resource option to resourceDatabase ([#211](https://www.github.com/googleapis/gapic-generator-typescript/issues/211)) ([7ea7034](https://www.github.com/googleapis/gapic-generator-typescript/commit/7ea703440db81902c3ba0839db4024b0d41c070e)) * add eslint disable instruction to system test fixture ([#147](https://www.github.com/googleapis/gapic-generator-typescript/issues/147)) ([68e8a14](https://www.github.com/googleapis/gapic-generator-typescript/commit/68e8a144083c7459a4f0e2c546fd5150aaa87913)) * add jsdoc to resource name methods ([#152](https://www.github.com/googleapis/gapic-generator-typescript/issues/152)) ([cc66e49](https://www.github.com/googleapis/gapic-generator-typescript/commit/cc66e49d73811d68a8eca08fa173a10e057bcd6e)) * add nested message resource to database ([#239](https://www.github.com/googleapis/gapic-generator-typescript/issues/239)) ([94779b4](https://www.github.com/googleapis/gapic-generator-typescript/commit/94779b4eec3e52b6a0c84746ae698595f13c526f)) * add proper warning message ([#97](https://www.github.com/googleapis/gapic-generator-typescript/issues/97)) ([6b277ef](https://www.github.com/googleapis/gapic-generator-typescript/commit/6b277ef25ef0c252986d965445fd2b187c580919)) * add templates to the package ([#75](https://www.github.com/googleapis/gapic-generator-typescript/issues/75)) ([980d2aa](https://www.github.com/googleapis/gapic-generator-typescript/commit/980d2aa1c61bb19c969039571847e9cdd465a9ee)) * add white space between clients ([#462](https://www.github.com/googleapis/gapic-generator-typescript/issues/462)) ([5305fcd](https://www.github.com/googleapis/gapic-generator-typescript/commit/5305fcd0749e4c6c489b5bf1051d64271ca1be77)) * better default exports in src/index.ts ([#120](https://www.github.com/googleapis/gapic-generator-typescript/issues/120)) ([95d757b](https://www.github.com/googleapis/gapic-generator-typescript/commit/95d757b06aac34449ed4658f659a503dc44aeca1)) * camelCase more proto identifiers ([#194](https://www.github.com/googleapis/gapic-generator-typescript/issues/194)) ([ad3c1e9](https://www.github.com/googleapis/gapic-generator-typescript/commit/ad3c1e93944fb4635f0ec51ab23ac941b293c7c4)) * client streaming do not have request ([#235](https://www.github.com/googleapis/gapic-generator-typescript/issues/235)) ([3043372](https://www.github.com/googleapis/gapic-generator-typescript/commit/30433726839e254222b64c65758cc254b0baeebc)) * clientConfig can be omitted ([#41](https://www.github.com/googleapis/gapic-generator-typescript/issues/41)) ([1e84aa3](https://www.github.com/googleapis/gapic-generator-typescript/commit/1e84aa3e5ec5965c31af90d7051be9a7a4373d6c)) * compatibility with gapic-generator ([#105](https://www.github.com/googleapis/gapic-generator-typescript/issues/105)) ([360d352](https://www.github.com/googleapis/gapic-generator-typescript/commit/360d352925b653d57fb90e2a60aa480194d2b05f)) * copy protos in common google gax and googleapis ([#236](https://www.github.com/googleapis/gapic-generator-typescript/issues/236)) ([fc54b35](https://www.github.com/googleapis/gapic-generator-typescript/commit/fc54b3507de64b0169e8e4998d8186094fbcb6cf)) * correct jsdoc for server streaming and pagination ([#171](https://www.github.com/googleapis/gapic-generator-typescript/issues/171)) ([3ec17f1](https://www.github.com/googleapis/gapic-generator-typescript/commit/3ec17f1b575fa36368330c8fdcd249a84648b7c8)) * correctly determine auto-paginated field ([#156](https://www.github.com/googleapis/gapic-generator-typescript/issues/156)) ([a2a88e3](https://www.github.com/googleapis/gapic-generator-typescript/commit/a2a88e35510a65769b97e9a53f619b010965eee4)) * disable auto-pagination for `SearchJobsForAlert` method in talent API ([#446](https://www.github.com/googleapis/gapic-generator-typescript/issues/446)) ([7e55bba](https://www.github.com/googleapis/gapic-generator-typescript/commit/7e55bbaedb03448207883d1f67da37518025efc4)) * disable auto-pagination for Talent API ([#281](https://www.github.com/googleapis/gapic-generator-typescript/issues/281)) ([02aa5e5](https://www.github.com/googleapis/gapic-generator-typescript/commit/02aa5e547ee847789550074227b4d0a69024698a)) * do not consider common protos and no-service protos when determining package name ([#79](https://www.github.com/googleapis/gapic-generator-typescript/issues/79)) ([fdc83b1](https://www.github.com/googleapis/gapic-generator-typescript/commit/fdc83b128445ece67ebc29745c23ae212be634ed)) * do not create empty license file ([#78](https://www.github.com/googleapis/gapic-generator-typescript/issues/78)) ([908dd14](https://www.github.com/googleapis/gapic-generator-typescript/commit/908dd14e8a4884eec34359ed5d3e3a8ced379526)) * do not try to generate code for common protos ([#82](https://www.github.com/googleapis/gapic-generator-typescript/issues/82)) ([105ecd1](https://www.github.com/googleapis/gapic-generator-typescript/commit/105ecd1bede9de78994b0981fd78f714208782a3)) * do not use console in system test ([#153](https://www.github.com/googleapis/gapic-generator-typescript/issues/153)) ([8344bf0](https://www.github.com/googleapis/gapic-generator-typescript/commit/8344bf09380252b6029038ea7471783509804795)) * don't insert underscores for retry codes ([#172](https://www.github.com/googleapis/gapic-generator-typescript/issues/172)) ([88f1e33](https://www.github.com/googleapis/gapic-generator-typescript/commit/88f1e33fe8c8a4e1113b53b0e818d8990234cd26)) * duplicate resource name ([#333](https://www.github.com/googleapis/gapic-generator-typescript/issues/333)) ([6170ffc](https://www.github.com/googleapis/gapic-generator-typescript/commit/6170ffca23557b0031014e2d7c2e6264a8bce751)) * empty request params ([#430](https://www.github.com/googleapis/gapic-generator-typescript/issues/430)) ([f398151](https://www.github.com/googleapis/gapic-generator-typescript/commit/f3981512c340fcfffeb3c51a925e24b09de6ac60)) * escape /*/ in method comments ([#178](https://www.github.com/googleapis/gapic-generator-typescript/issues/178)) ([599e23c](https://www.github.com/googleapis/gapic-generator-typescript/commit/599e23cb4efbe303e6a7f524e711347b002e2d6d)) * export this.operationsClient ([#166](https://www.github.com/googleapis/gapic-generator-typescript/issues/166)) ([17963fb](https://www.github.com/googleapis/gapic-generator-typescript/commit/17963fb5d6263fd1cb97961b1835cb3157148066)) * extra check for undefined ([#144](https://www.github.com/googleapis/gapic-generator-typescript/issues/144)) ([ddf67d1](https://www.github.com/googleapis/gapic-generator-typescript/commit/ddf67d193d50fb9817755c11680ab3089365dbcb)) * fix docker image with symlinks ([#244](https://www.github.com/googleapis/gapic-generator-typescript/issues/244)) ([bc5bc8c](https://www.github.com/googleapis/gapic-generator-typescript/commit/bc5bc8c2d1530ebcb249d6f74694e729c7e26c84)) * fix docker test ([#246](https://www.github.com/googleapis/gapic-generator-typescript/issues/246)) ([e90db03](https://www.github.com/googleapis/gapic-generator-typescript/commit/e90db03152d699d1d3711d66217f82324241c232)) * fix long running interface ([#151](https://www.github.com/googleapis/gapic-generator-typescript/issues/151)) ([cd3b388](https://www.github.com/googleapis/gapic-generator-typescript/commit/cd3b388826a57ed8f2b285b710908f5092bea0c6)) * fixing config name ([#53](https://www.github.com/googleapis/gapic-generator-typescript/issues/53)) ([eda7c44](https://www.github.com/googleapis/gapic-generator-typescript/commit/eda7c44deb954443cedc1b0ae43848a31865c75e)) * generated test fixes ([#155](https://www.github.com/googleapis/gapic-generator-typescript/issues/155)) ([cac5ca4](https://www.github.com/googleapis/gapic-generator-typescript/commit/cac5ca489dde4adbee7942ff93dd0f8ed3b614f7)) * gts linter complains about prefer-spread ([ade3ffa](https://www.github.com/googleapis/gapic-generator-typescript/commit/ade3ffab4c9be73d55f60a2625c1feb40b745cc4)) * ignore http-proxy-agent for webpack ([#159](https://www.github.com/googleapis/gapic-generator-typescript/issues/159)) ([9a87032](https://www.github.com/googleapis/gapic-generator-typescript/commit/9a870321cb924c58442d3af3513a4f239da24b0e)) * ignore img.shields.io in linkinator ([#228](https://www.github.com/googleapis/gapic-generator-typescript/issues/228)) ([e99f416](https://www.github.com/googleapis/gapic-generator-typescript/commit/e99f416c52432ecfd8c29e0558fd7eaf55f0a06d)) * import/require in system test for multiple services ([#146](https://www.github.com/googleapis/gapic-generator-typescript/issues/146)) ([5648cda](https://www.github.com/googleapis/gapic-generator-typescript/commit/5648cda037775a39158aa31f51f5b88109ab1004)) * include IAM into common services to ignore, refactor the code ([#233](https://www.github.com/googleapis/gapic-generator-typescript/issues/233)) ([1c09160](https://www.github.com/googleapis/gapic-generator-typescript/commit/1c091606d87f8bd03ecea907bddf7d1255afba32)) * Init mock request for server/bidi streaming method in test ([#313](https://www.github.com/googleapis/gapic-generator-typescript/issues/313)) ([e716513](https://www.github.com/googleapis/gapic-generator-typescript/commit/e716513b31c0568c3fee4f3cc6c9cd388aee0eb9)) * make generated test more TypeScript-y ([#93](https://www.github.com/googleapis/gapic-generator-typescript/issues/93)) ([128f4af](https://www.github.com/googleapis/gapic-generator-typescript/commit/128f4af500588be73069858d1465e5ddd5c925aa)) * make git log file readable by everyone ([#165](https://www.github.com/googleapis/gapic-generator-typescript/issues/165)) ([56569ee](https://www.github.com/googleapis/gapic-generator-typescript/commit/56569eecf50613e62d778f9d725562f9b2cb4316)) * make npm run baseline behave properly with symlinks ([#302](https://www.github.com/googleapis/gapic-generator-typescript/issues/302)) ([50d1a16](https://www.github.com/googleapis/gapic-generator-typescript/commit/50d1a16583f5a8008f467da2adfd7a770ee1b964)), closes [#240](https://www.github.com/googleapis/gapic-generator-typescript/issues/240) * make sure npm pack works ([#80](https://www.github.com/googleapis/gapic-generator-typescript/issues/80)) ([3ecdf4c](https://www.github.com/googleapis/gapic-generator-typescript/commit/3ecdf4c25aec044d418472277ee0d98749a91736)) * make sure npm run baseline creates proper symlinks ([#309](https://www.github.com/googleapis/gapic-generator-typescript/issues/309)) ([5bd8a48](https://www.github.com/googleapis/gapic-generator-typescript/commit/5bd8a484e21ac4701580aa8d92e0b6a9513f81a8)) * make sure the order of protos is fixed ([#216](https://www.github.com/googleapis/gapic-generator-typescript/issues/216)) ([b42d6db](https://www.github.com/googleapis/gapic-generator-typescript/commit/b42d6db7b8cc54f926d76575f932a164cebb2444)) * mapping proto types to TypeScript types ([#163](https://www.github.com/googleapis/gapic-generator-typescript/issues/163)) ([54b7ca8](https://www.github.com/googleapis/gapic-generator-typescript/commit/54b7ca85c2fbc4575af42ed0b0ad185456b4e399)) * minor fixes here and there ([#135](https://www.github.com/googleapis/gapic-generator-typescript/issues/135)) ([b8b9d65](https://www.github.com/googleapis/gapic-generator-typescript/commit/b8b9d653717855b6dbe3074cbc32a795f472ef7b)) * more minor fixes ([#111](https://www.github.com/googleapis/gapic-generator-typescript/issues/111)) ([4909e3c](https://www.github.com/googleapis/gapic-generator-typescript/commit/4909e3ca86eff55c2628b7d0b574b18d63731c3d)) * no double quotes in .jsdoc.js ([#301](https://www.github.com/googleapis/gapic-generator-typescript/issues/301)) ([0aa09e1](https://www.github.com/googleapis/gapic-generator-typescript/commit/0aa09e1db073ee19af012ef1abe33f67fd1ee873)) * no proto.list ([#91](https://www.github.com/googleapis/gapic-generator-typescript/issues/91)) ([0dbf468](https://www.github.com/googleapis/gapic-generator-typescript/commit/0dbf468a01aa3dff1ba589fb01164938b0028515)) * no ts-ignore in generated code ([#99](https://www.github.com/googleapis/gapic-generator-typescript/issues/99)) ([355cec8](https://www.github.com/googleapis/gapic-generator-typescript/commit/355cec872e9c75c9313fc705ea785540fa721bfc)) * now we need stubSimpleCall for longrunning ([#466](https://www.github.com/googleapis/gapic-generator-typescript/issues/466)) ([449fca4](https://www.github.com/googleapis/gapic-generator-typescript/commit/449fca4b4357dd16b896ae720f31a4ab5452d453)) * only import GaxCall if needed, and remove unused variables ([#374](https://www.github.com/googleapis/gapic-generator-typescript/issues/374)) ([8b762fb](https://www.github.com/googleapis/gapic-generator-typescript/commit/8b762fb59cfba4ab45d5ef39e03beabe4d348786)) * parameters should be camelcase in path template function ([#212](https://www.github.com/googleapis/gapic-generator-typescript/issues/212)) ([53520fa](https://www.github.com/googleapis/gapic-generator-typescript/commit/53520fabea2e021c3f067f4fff2255fa5a924cbc)) * parse proto packages without namespace correctly ([#202](https://www.github.com/googleapis/gapic-generator-typescript/issues/202)) ([5094bb9](https://www.github.com/googleapis/gapic-generator-typescript/commit/5094bb914311971f66b3012b9e73e6c0907602c0)) * pass x-goog-request-params to streaming methods ([#234](https://www.github.com/googleapis/gapic-generator-typescript/issues/234)) ([456fed0](https://www.github.com/googleapis/gapic-generator-typescript/commit/456fed05fc90b2803f161f19d774ab8d1eb68ecd)) * process messages from all files ([#418](https://www.github.com/googleapis/gapic-generator-typescript/issues/418)) ([6d4e8de](https://www.github.com/googleapis/gapic-generator-typescript/commit/6d4e8deca1effe5c15bfa03862b53dca2010742b)) * proper copyright year for generated .jsdoc.js ([#383](https://www.github.com/googleapis/gapic-generator-typescript/issues/383)) ([102e5d9](https://www.github.com/googleapis/gapic-generator-typescript/commit/102e5d9e6b351fb557607fb875f9b7ff6ad9828c)) * proper handling of paging field name ([#174](https://www.github.com/googleapis/gapic-generator-typescript/issues/174)) ([25871fb](https://www.github.com/googleapis/gapic-generator-typescript/commit/25871fb6c6854219e60cf332902b18b62aa5e039)) * proper licenses and proper link to Apache license ([#386](https://www.github.com/googleapis/gapic-generator-typescript/issues/386)) ([ce8e06d](https://www.github.com/googleapis/gapic-generator-typescript/commit/ce8e06d5199d83d9704d0216591b0596a1a80d6d)) * remove common protos in generated proto list ([#455](https://www.github.com/googleapis/gapic-generator-typescript/issues/455)) ([1c4bd49](https://www.github.com/googleapis/gapic-generator-typescript/commit/1c4bd496f962dd09a98a2ba7860fa9d49bc71d21)) * remove extra backslash from regex ([#145](https://www.github.com/googleapis/gapic-generator-typescript/issues/145)) ([973af3e](https://www.github.com/googleapis/gapic-generator-typescript/commit/973af3ea04e4d1a1a9ca9229644ed739d79877cc)) * remove extra logging ([#232](https://www.github.com/googleapis/gapic-generator-typescript/issues/232)) ([3f60d98](https://www.github.com/googleapis/gapic-generator-typescript/commit/3f60d9806b5d8f180b55117fd3189b9df2ee1d4f)) * remove extra space in template ([#396](https://www.github.com/googleapis/gapic-generator-typescript/issues/396)) ([444c109](https://www.github.com/googleapis/gapic-generator-typescript/commit/444c1097d49f3f4f0b6d38cd95300823935889cc)) * remove most of [@ts-ignores](https://www.github.com/ts-ignores) from the generated code ([#44](https://www.github.com/googleapis/gapic-generator-typescript/issues/44)) ([27dfea2](https://www.github.com/googleapis/gapic-generator-typescript/commit/27dfea21f21a77e363760023e1dafc3f61f2c2b6)) * remove the filter if protos in both googleapis and gax ([#229](https://www.github.com/googleapis/gapic-generator-typescript/issues/229)) ([8d73e62](https://www.github.com/googleapis/gapic-generator-typescript/commit/8d73e62be1d8f72702aac7af73bf75f7bd73739b)) * render subresponse_field as string if it is not null ([#346](https://www.github.com/googleapis/gapic-generator-typescript/issues/346)) ([a0e7b40](https://www.github.com/googleapis/gapic-generator-typescript/commit/a0e7b40d77be114d5e6a94d5a7b23b780b7e8231)) * resource ids can contain underscores and trailing characters ([#206](https://www.github.com/googleapis/gapic-generator-typescript/issues/206)) ([b5460e4](https://www.github.com/googleapis/gapic-generator-typescript/commit/b5460e48d11435513d6b7c937c574a9c2ff619b7)) * separate jsdoc with api version ([#127](https://www.github.com/googleapis/gapic-generator-typescript/issues/127)) ([263d168](https://www.github.com/googleapis/gapic-generator-typescript/commit/263d1682dd89c9b1aaad5f3cb2e135544b67e5bd)) * service host and port undefined, apiEndpoint incorrect ([#62](https://www.github.com/googleapis/gapic-generator-typescript/issues/62)) ([b172087](https://www.github.com/googleapis/gapic-generator-typescript/commit/b172087bae788e3fad01524b548e03446c2e6235)) * set default timeouts to 60000 ([#175](https://www.github.com/googleapis/gapic-generator-typescript/issues/175)) ([4f9ff79](https://www.github.com/googleapis/gapic-generator-typescript/commit/4f9ff7921adaea3d6486da4c12e11ea3b23d7dab)) * set linkinator to silent, concurrency 10 ([#319](https://www.github.com/googleapis/gapic-generator-typescript/issues/319)) ([f01cec6](https://www.github.com/googleapis/gapic-generator-typescript/commit/f01cec6a8d02b57954c06a01000069fff2a3293c)) * support request params {key} with no =value ([#436](https://www.github.com/googleapis/gapic-generator-typescript/issues/436)) ([bd71f7c](https://www.github.com/googleapis/gapic-generator-typescript/commit/bd71f7cc6c27604d9e906f526c4cc4687d1903c5)) * switch protoc IPATH order ([#227](https://www.github.com/googleapis/gapic-generator-typescript/issues/227)) ([abff60f](https://www.github.com/googleapis/gapic-generator-typescript/commit/abff60fe0b2956fcdd2967b96b8ee1e948244ea5)) * template for configuring jsdoc ([#298](https://www.github.com/googleapis/gapic-generator-typescript/issues/298)) ([4afadae](https://www.github.com/googleapis/gapic-generator-typescript/commit/4afadaeb84113bfae3733d32c16ed85d79c8564c)) * throw err when fail to get service name list ([#230](https://www.github.com/googleapis/gapic-generator-typescript/issues/230)) ([5621dc8](https://www.github.com/googleapis/gapic-generator-typescript/commit/5621dc8818b401824e30441cc2116e4b92661f01)) * trick renovate to update dependencies for us ([#240](https://www.github.com/googleapis/gapic-generator-typescript/issues/240)) ([2a94e91](https://www.github.com/googleapis/gapic-generator-typescript/commit/2a94e9114bc1acae9fdd360e7b88425cc26dd352)) * **deps:** update dependency protobufjs to ^6.8.9 ([#323](https://www.github.com/googleapis/gapic-generator-typescript/issues/323)) ([71e7a2d](https://www.github.com/googleapis/gapic-generator-typescript/commit/71e7a2daa077c15b54fd4ee6324ce40f27708ff2)) * trim trailing whitespace in code, templates, and generated code ([#188](https://www.github.com/googleapis/gapic-generator-typescript/issues/188)) ([096630c](https://www.github.com/googleapis/gapic-generator-typescript/commit/096630c71fc4b8b1ae67846f779b98ad3bb06f82)) * unit test template has wrong paging response type ([#382](https://www.github.com/googleapis/gapic-generator-typescript/issues/382)) ([cfd29ff](https://www.github.com/googleapis/gapic-generator-typescript/commit/cfd29ff66b6550f392f4076f7c9a2cb537a19f31)) * update dependency @types/js-yaml to ^3.12.4, update test script ([#487](https://www.github.com/googleapis/gapic-generator-typescript/issues/487)) ([638a587](https://www.github.com/googleapis/gapic-generator-typescript/commit/638a587edac13cf9e67cc00c346d22aa4d7f636f)) * use c8 for coverage ([#160](https://www.github.com/googleapis/gapic-generator-typescript/issues/160)) ([0dda49a](https://www.github.com/googleapis/gapic-generator-typescript/commit/0dda49accccf4f97cc838f5da5a868b118ce92de)) * use camel case for page token ([#173](https://www.github.com/googleapis/gapic-generator-typescript/issues/173)) ([8cac8e7](https://www.github.com/googleapis/gapic-generator-typescript/commit/8cac8e7ad0d86973316cec83c74cf7141f141654)) * use camel case for path template names ([#184](https://www.github.com/googleapis/gapic-generator-typescript/issues/184)) ([034d991](https://www.github.com/googleapis/gapic-generator-typescript/commit/034d991c2f5ba7386f454ccbdc398badf9f4171d)) * use compatible version of google-gax ([05d08f1](https://www.github.com/googleapis/gapic-generator-typescript/commit/05d08f1ebcda32450d37ec9575394db3419e5447)) * use jsdoc link syntax ([#316](https://www.github.com/googleapis/gapic-generator-typescript/issues/316)) ([b0b280f](https://www.github.com/googleapis/gapic-generator-typescript/commit/b0b280f9bdc3eae6e75d78d53dcaed185c6222f0)) * use pagination types from gax ([#136](https://www.github.com/googleapis/gapic-generator-typescript/issues/136)) ([d5d5b0b](https://www.github.com/googleapis/gapic-generator-typescript/commit/d5d5b0b28234ea7be6e8171cbb9ac81e27b6b8f9)) * use require.resolve to locate google-gax ([#76](https://www.github.com/googleapis/gapic-generator-typescript/issues/76)) ([1ff3617](https://www.github.com/googleapis/gapic-generator-typescript/commit/1ff3617f56ede2b5e2731295f42642c801ee6731)) * use TypeScript 3.6 in the generated code ([#162](https://www.github.com/googleapis/gapic-generator-typescript/issues/162)) ([c73974a](https://www.github.com/googleapis/gapic-generator-typescript/commit/c73974a7cdb819fe80ee7210cc33196118c841b8)) * **deps:** update dependency prettier to ^2.0.2 ([#353](https://www.github.com/googleapis/gapic-generator-typescript/issues/353)) ([5714803](https://www.github.com/googleapis/gapic-generator-typescript/commit/5714803ab5b2a4e632304cbb331113f3635cf1e0)) * use ubuntu-based image instead of alpine-based, update protoc ([#209](https://www.github.com/googleapis/gapic-generator-typescript/issues/209)) ([bf9663d](https://www.github.com/googleapis/gapic-generator-typescript/commit/bf9663d90700efb250af4f9a56d495da83918f1e)) * **deps:** update dependency get-stdin to v8 ([#480](https://www.github.com/googleapis/gapic-generator-typescript/issues/480)) ([8ff4be4](https://www.github.com/googleapis/gapic-generator-typescript/commit/8ff4be489e68fb24f2b7ff29d24115b81b1885f6)) * **deps:** update dependency google-gax to ^1.14.1 ([#272](https://www.github.com/googleapis/gapic-generator-typescript/issues/272)) ([367b81a](https://www.github.com/googleapis/gapic-generator-typescript/commit/367b81acb384fed48f02ad3060233b036edcf9ac)) * **deps:** update dependency google-gax to ^1.14.2 ([#300](https://www.github.com/googleapis/gapic-generator-typescript/issues/300)) ([6981baa](https://www.github.com/googleapis/gapic-generator-typescript/commit/6981baadade67126db5c58258e840c6cbebb5152)) * **deps:** update dependency google-gax to ^1.15.0 ([#335](https://www.github.com/googleapis/gapic-generator-typescript/issues/335)) ([6dc67d4](https://www.github.com/googleapis/gapic-generator-typescript/commit/6dc67d4268bb22af4c2b57f51716b0d16adada84)) * **deps:** update dependency google-gax to ^1.15.1 ([#337](https://www.github.com/googleapis/gapic-generator-typescript/issues/337)) ([65ea018](https://www.github.com/googleapis/gapic-generator-typescript/commit/65ea018508aac6800b9eeeca19110311617b6761)) * **deps:** update dependency google-gax to ^2.0.2 ([#381](https://www.github.com/googleapis/gapic-generator-typescript/issues/381)) ([f531b22](https://www.github.com/googleapis/gapic-generator-typescript/commit/f531b228dcdf2f2549323afe87f3391acd7f1312)) * **deps:** update dependency google-gax to ^2.1.0 ([#413](https://www.github.com/googleapis/gapic-generator-typescript/issues/413)) ([496b093](https://www.github.com/googleapis/gapic-generator-typescript/commit/496b093e5ec16b24ac14d5976ef1538b49e16b24)) * **deps:** update dependency google-gax to ^2.2.0 ([#415](https://www.github.com/googleapis/gapic-generator-typescript/issues/415)) ([39b2bd9](https://www.github.com/googleapis/gapic-generator-typescript/commit/39b2bd9b994a61f552cc839466f4e32376386fe1)) * **deps:** update dependency google-gax to ^2.3.0 ([#441](https://www.github.com/googleapis/gapic-generator-typescript/issues/441)) ([3e7c765](https://www.github.com/googleapis/gapic-generator-typescript/commit/3e7c76583873bf9e757ff9b2f40d66441c655b3c)) * **deps:** update dependency google-gax to v2 ([#364](https://www.github.com/googleapis/gapic-generator-typescript/issues/364)) ([130f2dc](https://www.github.com/googleapis/gapic-generator-typescript/commit/130f2dca1941e3797e7a8d38fced2c67303e9b71)) * **deps:** update dependency nunjucks to ^3.2.0 ([#273](https://www.github.com/googleapis/gapic-generator-typescript/issues/273)) ([156deac](https://www.github.com/googleapis/gapic-generator-typescript/commit/156deac0e20fb0a0b0a15645dfbc52d9d4bf51e5)) * **deps:** update dependency nunjucks to ^3.2.1 ([#336](https://www.github.com/googleapis/gapic-generator-typescript/issues/336)) ([a20db96](https://www.github.com/googleapis/gapic-generator-typescript/commit/a20db963751d2d374b302a79201caa8c6f2ae230)) * **deps:** update dependency object-hash to ^2.0.2 ([#274](https://www.github.com/googleapis/gapic-generator-typescript/issues/274)) ([cf47f68](https://www.github.com/googleapis/gapic-generator-typescript/commit/cf47f68441589c4fdb227b0b8f9c04dab0d55739)) * **deps:** update dependency object-hash to ^2.0.3 ([#282](https://www.github.com/googleapis/gapic-generator-typescript/issues/282)) ([cf40d0e](https://www.github.com/googleapis/gapic-generator-typescript/commit/cf40d0e2e033f3b01550efa88fdb9a5c2267e463)) * **deps:** update dependency prettier to ^2.0.1 ([#349](https://www.github.com/googleapis/gapic-generator-typescript/issues/349)) ([a96378e](https://www.github.com/googleapis/gapic-generator-typescript/commit/a96378ef742bb34fc2e3999a539a5fd053729f95)) * **deps:** update dependency prettier to ^2.0.4 ([#388](https://www.github.com/googleapis/gapic-generator-typescript/issues/388)) ([bc14dc8](https://www.github.com/googleapis/gapic-generator-typescript/commit/bc14dc87939b71f67532ddf12994f271f691c8a0)) * **deps:** update dependency prettier to ^2.0.5 ([#435](https://www.github.com/googleapis/gapic-generator-typescript/issues/435)) ([b0e0ce5](https://www.github.com/googleapis/gapic-generator-typescript/commit/b0e0ce5aa066021f42f1aa3c42ef703f82cb60c2)) * **deps:** update dependency prettier to v2 ([#348](https://www.github.com/googleapis/gapic-generator-typescript/issues/348)) ([da3c97b](https://www.github.com/googleapis/gapic-generator-typescript/commit/da3c97bf5e03c0fec9480eab583546868ab6ad27)) * **deps:** update dependency protobufjs to ^6.9.0 ([#432](https://www.github.com/googleapis/gapic-generator-typescript/issues/432)) ([1c9d9ca](https://www.github.com/googleapis/gapic-generator-typescript/commit/1c9d9cac13a07ee2d39c6c1525563c092ad94310)) * **deps:** update dependency tree-kill to ^1.2.2 ([#275](https://www.github.com/googleapis/gapic-generator-typescript/issues/275)) ([ef2d150](https://www.github.com/googleapis/gapic-generator-typescript/commit/ef2d1505b6441219f12aa0524167ae97f7aea871)) * **deps:** update dependency yargs to ^15.1.0 ([#276](https://www.github.com/googleapis/gapic-generator-typescript/issues/276)) ([b679734](https://www.github.com/googleapis/gapic-generator-typescript/commit/b679734b79c8f1636be3bf28cb48a0aabb39e044)) * **deps:** update dependency yargs to ^15.2.0 ([#310](https://www.github.com/googleapis/gapic-generator-typescript/issues/310)) ([0379b4c](https://www.github.com/googleapis/gapic-generator-typescript/commit/0379b4c9baf85d676380ef0db6fbfd2541c1db73)) * **deps:** update dependency yargs to ^15.3.0 ([#321](https://www.github.com/googleapis/gapic-generator-typescript/issues/321)) ([7ccd230](https://www.github.com/googleapis/gapic-generator-typescript/commit/7ccd230032d84d553b534b554b178f67a9c99073)) * **deps:** update dependency yargs to ^15.3.1 ([#334](https://www.github.com/googleapis/gapic-generator-typescript/issues/334)) ([ba6db7f](https://www.github.com/googleapis/gapic-generator-typescript/commit/ba6db7f9e193d717829113adfcd9fc71d0bd4930)) * **deps:** update dependency yargs to v15 ([#142](https://www.github.com/googleapis/gapic-generator-typescript/issues/142)) ([b920625](https://www.github.com/googleapis/gapic-generator-typescript/commit/b920625b4734d34d22d6a8b2c8b23ca2472f153f)) * wait for client before checking for terminate ([#186](https://www.github.com/googleapis/gapic-generator-typescript/issues/186)) ([cb9136d](https://www.github.com/googleapis/gapic-generator-typescript/commit/cb9136d27fc267ab483a203b60a3df9bbdfa2217)) * **deps:** use gts ^1.0.0 and typescript ~3.6.0 ([#90](https://www.github.com/googleapis/gapic-generator-typescript/issues/90)) ([685737c](https://www.github.com/googleapis/gapic-generator-typescript/commit/685737c2f753697aa2c42dc7dde72afdf53aed1c)) * **deps:** use typescript ~3.7.5 for now ([#289](https://www.github.com/googleapis/gapic-generator-typescript/issues/289)) ([ec9e4d8](https://www.github.com/googleapis/gapic-generator-typescript/commit/ec9e4d8fcf35ace3328b9b8f83133dcdf21fe3e5)) ### Code Refactoring * bazel build ([#442](https://www.github.com/googleapis/gapic-generator-typescript/issues/442)) ([79a5eaf](https://www.github.com/googleapis/gapic-generator-typescript/commit/79a5eafc18eb2d3e774cb957c389dee11069b11b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.