fix: do not use console in system test (#153)

* fix: do not use console in system test * fix: baselines
googleapis · Nov 20, 2019 · 8344bf0 · 8344bf0
1 parent cd3b388
commit 8344bf0
Show file tree

Hide file tree

Showing 24 changed files with 12 additions and 30 deletions.
diff --git a/templates/typescript_gapic/system-test/.eslintrc.yml.njk b/templates/typescript_gapic/system-test/.eslintrc.yml.njk
@@ -18,5 +18,4 @@ limitations under the License.
 ---
 env:
   mocha: true
-rules:
-  no-console: off
+
diff --git a/templates/typescript_gapic/system-test/fixtures/sample/src/index.js.njk b/templates/typescript_gapic/system-test/fixtures/sample/src/index.js.njk
@@ -24,7 +24,6 @@ const {{ api.naming.productName.toKebabCase()}} = require('{{ api.publishName }}
 function main() {
 {%- for service in api.services %}
   const {{ service.name.toCamelCase() -}}Client = new {{ api.naming.productName.toKebabCase() }}.{{ service.name.toPascalCase() + 'Client' }}();
-  console.log("{{- service.name.toCamelCase() -}}Client was created!");
 {%- endfor %}
 }
 

diff --git a/templates/typescript_gapic/system-test/fixtures/sample/src/index.ts.njk b/templates/typescript_gapic/system-test/fixtures/sample/src/index.ts.njk
@@ -28,7 +28,6 @@ import {
 function main() {
 {%- for service in api.services %}
   const {{ service.name.toCamelCase() -}}Client = new {{ service.name.toPascalCase() + 'Client' -}}();
-  console.log("{{- service.name.toCamelCase() -}}Client was created!");
 {%- endfor %}
 }
 

diff --git a/templates/typescript_gapic/system-test/install.ts.njk b/templates/typescript_gapic/system-test/install.ts.njk
@@ -17,7 +17,7 @@ limitations under the License.
 -#}
 {% import "../_license.njk" as license -%}
 {{license.license()}}
-import {packNTest} from 'pack-n-play';
+import { packNTest } from 'pack-n-play';
 import { readFileSync } from 'fs';
 
 describe('typescript consumer tests', () => {

diff --git a/typescript/test/testdata/keymanager/system-test/.eslintrc.yml.baseline b/typescript/test/testdata/keymanager/system-test/.eslintrc.yml.baseline
@@ -1,5 +1,4 @@
 ---
 env:
   mocha: true
-rules:
-  no-console: off
+
diff --git a/typescript/test/testdata/keymanager/system-test/fixtures/sample/src/index.js.baseline b/typescript/test/testdata/keymanager/system-test/fixtures/sample/src/index.js.baseline
@@ -22,7 +22,6 @@ const kms = require('kms');
 
 function main() {
   const keyManagementServiceClient = new kms.KeyManagementServiceClient();
-  console.log("keyManagementServiceClient was created!");
 }
 
 main();
diff --git a/typescript/test/testdata/keymanager/system-test/fixtures/sample/src/index.ts.baseline b/typescript/test/testdata/keymanager/system-test/fixtures/sample/src/index.ts.baseline
@@ -20,7 +20,6 @@ import {KeyManagementServiceClient} from 'kms';
 
 function main() {
   const keyManagementServiceClient = new KeyManagementServiceClient();
-  console.log("keyManagementServiceClient was created!");
 }
 
 main();
diff --git a/typescript/test/testdata/keymanager/system-test/install.ts.baseline b/typescript/test/testdata/keymanager/system-test/install.ts.baseline
@@ -16,7 +16,7 @@
 // ** https://github.com/googleapis/gapic-generator-typescript **
 // ** All changes to this file may be overwritten. **
 
-import {packNTest} from 'pack-n-play';
+import { packNTest } from 'pack-n-play';
 import { readFileSync } from 'fs';
 
 describe('typescript consumer tests', () => {

diff --git a/typescript/test/testdata/redis/system-test/.eslintrc.yml.baseline b/typescript/test/testdata/redis/system-test/.eslintrc.yml.baseline
@@ -1,5 +1,4 @@
 ---
 env:
   mocha: true
-rules:
-  no-console: off
+
diff --git a/typescript/test/testdata/redis/system-test/fixtures/sample/src/index.js.baseline b/typescript/test/testdata/redis/system-test/fixtures/sample/src/index.js.baseline
@@ -22,7 +22,6 @@ const redis = require('redis');
 
 function main() {
   const cloudRedisClient = new redis.CloudRedisClient();
-  console.log("cloudRedisClient was created!");
 }
 
 main();
diff --git a/typescript/test/testdata/redis/system-test/fixtures/sample/src/index.ts.baseline b/typescript/test/testdata/redis/system-test/fixtures/sample/src/index.ts.baseline
@@ -20,7 +20,6 @@ import {CloudRedisClient} from 'redis';
 
 function main() {
   const cloudRedisClient = new CloudRedisClient();
-  console.log("cloudRedisClient was created!");
 }
 
 main();
diff --git a/typescript/test/testdata/redis/system-test/install.ts.baseline b/typescript/test/testdata/redis/system-test/install.ts.baseline
@@ -16,7 +16,7 @@
 // ** https://github.com/googleapis/gapic-generator-typescript **
 // ** All changes to this file may be overwritten. **
 
-import {packNTest} from 'pack-n-play';
+import { packNTest } from 'pack-n-play';
 import { readFileSync } from 'fs';
 
 describe('typescript consumer tests', () => {

diff --git a/typescript/test/testdata/showcase/system-test/.eslintrc.yml.baseline b/typescript/test/testdata/showcase/system-test/.eslintrc.yml.baseline
@@ -1,5 +1,4 @@
 ---
 env:
   mocha: true
-rules:
-  no-console: off
+
diff --git a/typescript/test/testdata/showcase/system-test/fixtures/sample/src/index.js.baseline b/typescript/test/testdata/showcase/system-test/fixtures/sample/src/index.js.baseline
@@ -22,7 +22,6 @@ const showcase = require('showcase');
 
 function main() {
   const echoClient = new showcase.EchoClient();
-  console.log("echoClient was created!");
 }
 
 main();
diff --git a/typescript/test/testdata/showcase/system-test/fixtures/sample/src/index.ts.baseline b/typescript/test/testdata/showcase/system-test/fixtures/sample/src/index.ts.baseline
@@ -20,7 +20,6 @@ import {EchoClient} from 'showcase';
 
 function main() {
   const echoClient = new EchoClient();
-  console.log("echoClient was created!");
 }
 
 main();
diff --git a/typescript/test/testdata/showcase/system-test/install.ts.baseline b/typescript/test/testdata/showcase/system-test/install.ts.baseline
@@ -16,7 +16,7 @@
 // ** https://github.com/googleapis/gapic-generator-typescript **
 // ** All changes to this file may be overwritten. **
 
-import {packNTest} from 'pack-n-play';
+import { packNTest } from 'pack-n-play';
 import { readFileSync } from 'fs';
 
 describe('typescript consumer tests', () => {

diff --git a/typescript/test/testdata/texttospeech/system-test/.eslintrc.yml.baseline b/typescript/test/testdata/texttospeech/system-test/.eslintrc.yml.baseline
@@ -1,5 +1,4 @@
 ---
 env:
   mocha: true
-rules:
-  no-console: off
+
diff --git a/typescript/test/testdata/texttospeech/system-test/fixtures/sample/src/index.js.baseline b/typescript/test/testdata/texttospeech/system-test/fixtures/sample/src/index.js.baseline
@@ -22,7 +22,6 @@ const texttospeech = require('@google-cloud/text-to-speech');
 
 function main() {
   const textToSpeechClient = new texttospeech.TextToSpeechClient();
-  console.log("textToSpeechClient was created!");
 }
 
 main();
diff --git a/typescript/test/testdata/texttospeech/system-test/fixtures/sample/src/index.ts.baseline b/typescript/test/testdata/texttospeech/system-test/fixtures/sample/src/index.ts.baseline
@@ -20,7 +20,6 @@ import {TextToSpeechClient} from '@google-cloud/text-to-speech';
 
 function main() {
   const textToSpeechClient = new TextToSpeechClient();
-  console.log("textToSpeechClient was created!");
 }
 
 main();
diff --git a/typescript/test/testdata/texttospeech/system-test/install.ts.baseline b/typescript/test/testdata/texttospeech/system-test/install.ts.baseline
@@ -16,7 +16,7 @@
 // ** https://github.com/googleapis/gapic-generator-typescript **
 // ** All changes to this file may be overwritten. **
 
-import {packNTest} from 'pack-n-play';
+import { packNTest } from 'pack-n-play';
 import { readFileSync } from 'fs';
 
 describe('typescript consumer tests', () => {

diff --git a/typescript/test/testdata/translate/system-test/.eslintrc.yml.baseline b/typescript/test/testdata/translate/system-test/.eslintrc.yml.baseline
@@ -1,5 +1,4 @@
 ---
 env:
   mocha: true
-rules:
-  no-console: off
+
diff --git a/typescript/test/testdata/translate/system-test/fixtures/sample/src/index.js.baseline b/typescript/test/testdata/translate/system-test/fixtures/sample/src/index.js.baseline
@@ -22,7 +22,6 @@ const translation = require('translation');
 
 function main() {
   const translationServiceClient = new translation.TranslationServiceClient();
-  console.log("translationServiceClient was created!");
 }
 
 main();
diff --git a/typescript/test/testdata/translate/system-test/fixtures/sample/src/index.ts.baseline b/typescript/test/testdata/translate/system-test/fixtures/sample/src/index.ts.baseline
@@ -20,7 +20,6 @@ import {TranslationServiceClient} from 'translation';
 
 function main() {
   const translationServiceClient = new TranslationServiceClient();
-  console.log("translationServiceClient was created!");
 }
 
 main();
diff --git a/typescript/test/testdata/translate/system-test/install.ts.baseline b/typescript/test/testdata/translate/system-test/install.ts.baseline
@@ -16,7 +16,7 @@
 // ** https://github.com/googleapis/gapic-generator-typescript **
 // ** All changes to this file may be overwritten. **
 
-import {packNTest} from 'pack-n-play';
+import { packNTest } from 'pack-n-play';
 import { readFileSync } from 'fs';
 
 describe('typescript consumer tests', () => {
-Original file line number
+Diff line change
@@ Expand Up / @@ -18,5 +18,4 @@ limitations under the License. @@
     ---
     env:
       mocha: true
-    rules:
-      no-console: off