Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to protoc inputs to GenerateProtoTask #560

Merged

Commits on May 3, 2022

  1. Ignore OS as an input to GenerateProtoTask

    This change will remove the OS from the input properties of the
    GenerateProtoTask when `protoc` or a plugin is defined as a resolvable
    artifact. The expectation is that same versions of `protoc` or plugins
    will produce same outputs regardless of the OS on which they are run.
    
    This is done by creating marking `alternativePaths` as Internal for
    backwards compatibility and creating two new properties:
    `releaseArtifacts` and `snapshotArtifacts`. `releaseArtifacts` will
    contain "$groupId:$artifact:$version" for each non-snapshot dependency,
    effectively ignoring OS for these dependencies. `snapshotArtifacts` will
    contain each snapshot artifact in a `FileCollection` since the
    snapshots cannot be matched solely by their maven coordinates.
    
    See google#457.
    clayburn committed May 3, 2022
    Configuration menu
    Copy the full SHA
    8df229f View commit details
    Browse the repository at this point in the history

Commits on May 4, 2022

  1. Add UP-TO-DATE tests for changing artifacts

    This test should cover google#528 and show that it is no longer an issue.
    clayburn committed May 4, 2022
    Configuration menu
    Copy the full SHA
    bd499dd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a92e8eb View commit details
    Browse the repository at this point in the history
  3. Add UP-TO-DATE tests for changing paths

    This test should cover google#557.
    clayburn committed May 4, 2022
    Configuration menu
    Copy the full SHA
    53bba1f View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2022

  1. Fix CodeNarc violations

    clayburn committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    19b52b6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    56d5875 View commit details
    Browse the repository at this point in the history