Fixes to protoc inputs to GenerateProtoTask
#560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will remove the OS from the input properties of the GenerateProtoTask when `protoc` or a plugin is defined as a resolvable artifact. The expectation is that same versions of `protoc` or plugins will produce same outputs regardless of the OS on which they are run. This is done by creating marking `alternativePaths` as Internal for backwards compatibility and creating two new properties: `releaseArtifacts` and `snapshotArtifacts`. `releaseArtifacts` will contain "$groupId:$artifact:$version" for each non-snapshot dependency, effectively ignoring OS for these dependencies. `snapshotArtifacts` will contain each snapshot artifact in a `FileCollection` since the snapshots cannot be matched solely by their maven coordinates. See google#457.
This test should cover google#528 and show that it is no longer an issue.
This test should cover google#557.
YifeiZhuang
approved these changes
Jun 3, 2022
ejona86
reviewed
Jun 6, 2022
src/main/groovy/com/google/protobuf/gradle/GenerateProtoTask.groovy
Outdated
Show resolved
Hide resolved
src/main/groovy/com/google/protobuf/gradle/GenerateProtoTask.groovy
Outdated
Show resolved
Hide resolved
ejona86
approved these changes
Jun 6, 2022
This was referenced Jun 6, 2022
|
@clayburn, thank you! |
|
@ejona86 - I've gotten a few pings about this PR. Are there any plans to make a release including this? |
|
The release is done. Unfortunately, the coordinates changed, which may cause problems for some people. Apparently just adding maven-publish plugin to the build changes the behavior of the plugin-publish plugin (gradle/plugin-portal-requests#124). So I think I'll do another release. Release 0.8.19 is safe to use, but just annoying. |
|
Actually... I guess I won't, and will just leave it as-is. Looking at the plugin-publish 1.0.0 release notes seems this is "the new way of doing things." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #457 and #557