Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenerateProtoTask does not consider path-based protoc or plugins as task inputs #557

Closed
clayburn opened this issue Apr 29, 2022 · 1 comment

Comments

@clayburn
Copy link
Contributor

If you set protoc by path rather than by artifact, the GenerateProtoTask does not consider that to be a task input. For example this buildscript:

val protocPath: String? = System.getenv("PROTOC_PATH")
protobuf {
    protoc {
        path = protocPath
    }
}

results in the following:

> PROTOC_PATH=proto-3.19.3/bin/protoc ./gradlew generateProto
> Task :proj:generateProto

> PROTOC_PATH=proto-3.20.1/bin/protoc ./gradlew generateProto
> Task :proj:generateProto UP-TO-DATE

The same also holds true for plugins defined by a path instead of an artifact specification.

clayburn added a commit to clayburn/protobuf-gradle-plugin that referenced this issue May 3, 2022
clayburn added a commit to clayburn/protobuf-gradle-plugin that referenced this issue May 4, 2022
clayburn added a commit to clayburn/protobuf-gradle-plugin that referenced this issue May 4, 2022
@ejona86
Copy link
Collaborator

ejona86 commented Jun 6, 2022

Fixed by #560

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants