Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support deleting head branch of GitHub pull requests #1245

Closed
TomTucka opened this issue Aug 6, 2019 · 12 comments · Fixed by #1388
Closed

Support deleting head branch of GitHub pull requests #1245

TomTucka opened this issue Aug 6, 2019 · 12 comments · Fixed by #1388

Comments

@TomTucka
Copy link

TomTucka commented Aug 6, 2019

add support for this new feature: https://help.github.com/en/articles/managing-the-automatic-deletion-of-branches

@stefansedich
Copy link
Contributor

I might be blind but looking at the V3 Repositories API I cannot see this being part of it...

@TomTucka
Copy link
Author

TomTucka commented Aug 7, 2019

@stefansedich Yep! I have asked @githubhelp on twitter. Will post a response when they reply

@TomTucka
Copy link
Author

Confirmed by @githubhelp on twitter that this is not in the v3 or v4 API. They are going to check if its on the engineering teams roadmap.

@gmlewis
Copy link
Collaborator

gmlewis commented Aug 23, 2019

Closing due to lack of support in the v3 API. Please reopen if it becomes supported.

@cmardonespino
Copy link

@TomTucka Amigo, exists new news about this? I think that it could be pretty usefull if this feature is support for terraform!

@eriksw
Copy link

eriksw commented Jan 17, 2020

@gmlewis Please reopen—GitHub seem to have added this to the api.

Looking at the documentation I see delete_branch_on_merge as a parameter for repo create and edit.

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 18, 2020

Cool! Thank you, all!

This would be a great PR for any new contributor to this repo or a new Go developer.
All contributions are greatly appreciated!

Feel free to volunteer for any issue and the issue can be assigned to you so that others don't attempt to duplicate the work.

Please check out our CONTRIBUTING.md guide to get started.

Thank you!

@stefansedich
Copy link
Contributor

stefansedich commented Jan 18, 2020

@gmlewis I will pick this up been waiting for the API change long enough may as well see it home 😄 can you assign it to me? will try get to it over the weekend.

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 18, 2020

Thank you, @stefansedich! It's yours.

@TomTucka
Copy link
Author

TomTucka commented Jan 20, 2020

@stefansedich Can you ping me when this is done? or I can do it if you want? I'd like to add support for this to the terraform provider for GitHub

@stefansedich
Copy link
Contributor

Sorry @TomTucka was out all weekend, only just sat down and got the PR up!

@stefansedich
Copy link
Contributor

@TomTucka I don't mind picking up the Terraform module side once #1388 gets merged.

n1lesh pushed a commit to n1lesh/go-github that referenced this issue Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants