Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: support deleting head branch of Github pull requests #264

Closed
vinniegarcia opened this issue Aug 1, 2019 · 8 comments · Fixed by #399
Closed

Feature request: support deleting head branch of Github pull requests #264

vinniegarcia opened this issue Aug 1, 2019 · 8 comments · Fixed by #399
Assignees
@TomTucka
Labels
Type: Feature New feature or request
Milestone
v2.6.0

Comments

@vinniegarcia
Copy link

Requesting that you support the new feature to automatically delete the head branch of pull requests that Github just announced here: https://help.github.com/en/articles/managing-the-automatic-deletion-of-branches. A small thing but it saves manual effort. Thanks in advance!
@TomTucka
Copy link

TomTucka commented Aug 6, 2019

Happy to do this as soon as go-github support it, I raised an issue over on their repository: google/go-github#1245

@TomTucka TomTucka mentioned this issue Aug 6, 2019
Closed
@tracypholmes tracypholmes added the Type: Feature New feature or request label Aug 8, 2019
@skeggse
Copy link

skeggse commented Jan 27, 2020

Cross-linking for reference: google/go-github#1388

@mwarkentin mwarkentin mentioned this issue Jan 28, 2020
Closed
@jakebiesinger-onduo
Copy link
Contributor

This is now available in go-github v29. I have a PR for the corresponding terraform-provider-github changes, but I don't know how to update the vendor directory there. Any pointers?

@springerigor
Copy link
Contributor

@jakebiesinger-onduo Please try with go mod vendor.

@jakebiesinger-onduo
Copy link
Contributor

Thanks, @springerigor. I've opened #342 though there are still a few issues with the PR.

@marcinswigon marcinswigon mentioned this issue Feb 12, 2020
Closed
@TomTucka
Copy link

Can someone assign this to me? I'll get it finished this week

@jspiro
Copy link
Contributor

jspiro commented Mar 20, 2020

Would still love to see this if it's possible :)

@gevalter
Copy link

We also waiting for this feature, tell me if i can help

@jcudit jcudit added this to the v2.6.0 milestone Mar 30, 2020
bltavares referenced this issue in bltavares/terraform-provider-github Mar 30, 2020
@bltavares
Introduce option to manage Delete Branch on Merge
9a5df46 
Since [this commit](google/go-github#1388) it
is possible to manage if the project should close branches automatically
after a PR is merged.

The current version on this project already supports this new config.

This commit introduces the new option, using the same default as the
GitHub API uses.

Fix https://github.com/terraform-providers/terraform-provider-github/issues/264
@bltavares bltavares mentioned this issue Mar 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TomTucka TomTucka

Labels
Type: Feature New feature or request
Projects
None yet
Milestone
v2.6.0
9 participants
@jspiro @skeggse @vinniegarcia @TomTucka @springerigor @jcudit @tracypholmes @gevalter @jakebiesinger-onduo