Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete branch on PR merge #109

Closed
damacus opened this issue Oct 7, 2019 · 9 comments
Closed

Delete branch on PR merge #109

damacus opened this issue Oct 7, 2019 · 9 comments

Comments

@damacus
Copy link
Member

damacus commented Oct 7, 2019

Add the github action to remove merged branches.

@shreyasbapat
Copy link
Contributor

Addressed in #113

@JohnRoesler
Copy link
Contributor

Unfortunately the documentation in jessfraz/branch-cleanup-action is out of date. I've taken a pass at following the syntax, but the action is not actually deleting the branch at the moment https://github.com/sous-chefs/meta/blob/master/.github/workflows/main.yml

Something to poke some more and see if maybe it needs a run command or if that script is actually working.

@JohnRoesler
Copy link
Contributor

Thank you @PowerSchill for solving this one - needed to be run on closed action https://github.com/sous-chefs/meta/blob/master/.github/workflows/main.yml#L5

@PowerSchill
Copy link
Contributor

Reopening so I can track implementation.

This was referenced Oct 12, 2019
@majormoses
Copy link

Github now supports this natively but did not expose the setting in the v3 or v4 api.

@JohnRoesler
Copy link
Contributor

I can confirm it's there in the settings. So much for a cool GitHub action to take care of it

@JohnRoesler JohnRoesler self-assigned this Oct 13, 2019
@PowerSchill
Copy link
Contributor

Yeah, I saw that but also noticed the terraform provider for GitHub didn't seem to support that setting. The actions do open up possibilities for other things so as a learning experience it was valuable.

@xorima
Copy link
Contributor

xorima commented Oct 14, 2019

all merged

@xorima xorima closed this as completed Oct 14, 2019
@JohnRoesler
Copy link
Contributor

We decided to use the github action route to auto delete branches as the github api does not have the delete branch setting exposed and so we can't work that into the terraform provider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants