Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ja: Translate Chapter 24 (Generics) #1283

Merged
merged 4 commits into from
Oct 4, 2023

Conversation

kantasv
Copy link
Collaborator

@kantasv kantasv commented Sep 30, 2023

Hi JP translation folks (#652). Here's a MR for Generics chapter. Could you take a look at it? Thank you!

Copy link
Collaborator

@keiichiw keiichiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request! Here are my review comments

po/ja.po Outdated Show resolved Hide resolved
po/ja.po Outdated Show resolved Hide resolved
po/ja.po Outdated Show resolved Hide resolved
@kantasv
Copy link
Collaborator Author

kantasv commented Oct 3, 2023

Thanks @keiichiw, I applied changes based on your review. When you have some time could you review the diff once again? Have a good day.

@kantasv
Copy link
Collaborator Author

kantasv commented Oct 3, 2023

Tiny modification: In the previous commit (0d20784), I translated the concrete field type -> フィールドを持つ具象型 to make it sound more natural.

po/ja.po Outdated Show resolved Hide resolved
@keiichiw keiichiw merged commit d59cb11 into google:main Oct 4, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants