Make find_offers() an Executor method; handle offer proposals concurrently #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadeofblue
reviewed
Apr 7, 2021
| iter(common_platforms) | ||
| ) | ||
| else: | ||
| # reject proposal if there are no common payment platforms |
There was a problem hiding this comment.
seems like there could be a _reject_proposal(proposal, reason) method to handle the proposal rejections...
azawlocki
force-pushed
the
az/refactor-find-offers
branch
from
22be8cd to
a0f92df
Compare
azawlocki
force-pushed
the
az/refactor-find-offers
branch
from
5c5cdf4 to
fa1c1a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #304
Changes:
find_offers(), previously an inner coroutine defined inExecutor._submit(), is made a method ofExecutor.Executor.SubmissionStatethat gathers some pieces of data related to a single call toExecutor.submit()is added; for now it includes the parts required byfind_offers().asynciotask is spawned byfind_offers(); the number of tasks is limited (currently 5), if this number is reached, a new proposal must wait until a slot becomes available.yapapiis not picking up offers from market sometimes #304: 5 sec request timeouts are added toSubscription.respond()and.reject()methods in the market API.