Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executor shutdown takes long time (like 30 minutes) #101

Closed
mbenke opened this issue Apr 1, 2021 · 5 comments
Closed

Executor shutdown takes long time (like 30 minutes) #101

mbenke opened this issue Apr 1, 2021 · 5 comments

Comments

@mbenke
Copy link

mbenke commented Apr 1, 2021

Example:

[2021-04-01 13:30:41,677 ERROR yapapi.summary] Computation failed, reason: (408)
... [destroying activities]
[2021-04-01 13:30:44,287 INFO yapapi.executor] Waiting for 28 workers to finish...
[2021-04-01 13:30:52,033 DEBUG yapapi.executor] Terminating agreements...
...
[2021-04-01 13:36:12,718 DEBUG yapapi.executor] 1 service still running: {<Task pending coro=<Executor._submit.<locals>.find_offers() running at /root/miniconda3/envs/rdkit\
/lib/python3.7/site-packages/yapapi/executor/__init__.py:445> wait_for=<Future cancelled>>}
[2021-04-01 13:36:12,718 DEBUG yapapi.executor] Cancelling task: <Task pending coro=<Executor._submit.<locals>.find_offers() running at /root/miniconda3/envs/rdkit/lib/pyth\
on3.7/site-packages/yapapi/executor/__init__.py:445> wait_for=<Future cancelled>>
...
[NB lots of ProposalReceived/ProposalResponded/ProposalFailed here]
...
[2021-04-01 14:02:44,688 DEBUG yapapi.executor] Executor is shutting down...
[2021-04-01 14:02:44,759 DEBUG yapapi.events] ShutdownFinished(exc_info=None)
[2021-04-01 14:02:44,760 INFO yapapi.summary] Total cost: 12.15269563619010337
[2021-04-01 14:02:44,760 INFO yapapi.summary] Executor has shut down
[2021-04-01 14:02:44,761 DEBUG yapapi.executor.utils] AsyncWrapper's worker task cancelled

It occurs randomly, but often enough to be noticable (and painfil in long-running computations)

@filipgolem
Copy link

So, find_offers is still running, it is then cancelled and there are lots of Proposal* events before it's stopped.
golemfactory/yapapi#306 may fix this problem.

@mbenke
Copy link
Author

mbenke commented Apr 1, 2021

Full log:

yagna-issue101.log.gz

@azawlocki
Copy link

A fix is here: golemfactory/yapapi#308

@mateuszsrebrny
Copy link

@azawlocki so - it should be fixed, right? should I close the issue now?

@mateuszsrebrny
Copy link

the fix is merged, packages are released closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants