Rewrite find_offers() so that CancelledError is not caught
#308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azawlocki
commented
Apr 1, 2021
| ) | ||
| async def reject_proposal(proposal, reason): | ||
| await proposal.reject(reason=reason) | ||
| emit(events.ProposalRejected(prop_id=proposal.id, reason=reason)) |
There was a problem hiding this comment.
It's safer not to catch any exceptions here and let them bubble up
azawlocki
commented
Apr 1, 2021
Comment on lines
-418
to
-420
| except InvalidPropertiesError as err: | ||
| await reject_proposal(proposal, "Malformed offer") | ||
| continue |
There was a problem hiding this comment.
This error will be handled by except Exception at the end of find_offers().
filipgolem
approved these changes
Apr 2, 2021
azawlocki
force-pushed
the
az/find-offers-cancellation
branch
from
7e1eba2 to
eff6468
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python up to 3.7,
asyncio.CancelledErroris a subclass ofException, so one has to be careful in order not to interceptCancelledErrorwith anexcept Exceptionclause.Fixes golemfactory/yagna-triage#101