-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yapapi
is not picking up offers from market sometimes
#304
Labels
Comments
Example log snippet ending with a call to
to which
|
azawlocki
changed the title
Make market operations more concurrent
Make market operationsconcurrent
Mar 30, 2021
azawlocki
changed the title
Make market operationsconcurrent
Make market operations concurrent
Mar 30, 2021
Timings for
|
azawlocki
changed the title
Make market operations concurrent
Mar 30, 2021
yapapi
is not picking up offers from market sometimes
Timeouts and other fixes for |
This was referenced Mar 30, 2021
Another example: 2021-03-30_19:23:13.zip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently market operations (collecting offers, scoring them, rejecting / countering) are performed sequentially by a single
asyncio
taskfind_offers()
. It turns out that some market API calls can take well over a minute to complete (confirmed forRejectProposalOffer
andCounterProposalDemand
withyagna-0.6.3
with > 100 proposals onpublic-beta
/mainnet
).yapapi
should not wait for such long-running calls to return before processing next offers.Alternatively, we could just set a request timeout for (some) market operations to 5 s, as in
yajsapi
, this could be the best solution.The text was updated successfully, but these errors were encountered: