Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ResourceLoader: Report error if resource type unrecognized" #99469

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

akien-mga
Copy link
Member

PR #97370 actually seems benign and correct, but it seems to be exposing a pre-existing issue when the r_error code is now set and bubbles up. Ideally we'd just give this a bit of time to find a fixup, but we're about to build 4.4-dev5 right now and would prefer not to have a known regression on refactoring in an update that's centered around refactoring (UIDs).

So we're doing a quick revert for now, to re-try that PR (third time's the charm!) later on. CC @RandomShaper

@akien-mga akien-mga added bug topic:core regression cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Nov 20, 2024
@akien-mga akien-mga added this to the 4.4 milestone Nov 20, 2024
@akien-mga akien-mga requested a review from a team as a code owner November 20, 2024 15:53
@akien-mga akien-mga merged commit 9e60984 into godotengine:master Nov 20, 2024
19 checks passed
@akien-mga akien-mga deleted the revert-97370 branch November 20, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release regression topic:core
Projects
None yet
2 participants