ResourceLoader: Report error if resource type unrecognized (reverted) #97370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomShaper
added
bug
topic:core
cherrypick:4.3
|
Cherry-pick for 4.3 included in #96606. |
RandomShaper
force-pushed
the
refix_rl_not_found
branch
from
aa296b5 to
7758ede
Compare
Co-authored-by: Summersay415 <[email protected]>
RandomShaper
force-pushed
the
refix_rl_not_found
branch
from
7758ede to
fe21913
Compare
|
@Summersay415, I've integrated your changes and made further changes so error handling is clearer. |
|
@RandomShaper Have you tested this now with the latest version? |
|
Yes, works as expected. |
|
Thanks! |
akien-mga
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed version of the reverted #95508.
Not tested yet, but maybe a brave reviewer can confirm this is good now.Fixes #95490.