Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance/fix MT-processing related things #77145

Merged
merged 2 commits into from
May 17, 2023
Merged

Enhance/fix MT-processing related things #77145

merged 2 commits into from
May 17, 2023

Conversation

RandomShaper
Copy link
Member

  • Let calls through thread guards in resource loading contexts.
  • Optimize threading-sensitive node data for single-threaded processing.

@RandomShaper RandomShaper added this to the 4.1 milestone May 17, 2023
@RandomShaper RandomShaper requested a review from reduz May 17, 2023 00:00
@RandomShaper RandomShaper requested review from a team as code owners May 17, 2023 00:00
akien-mga
akien-mga reviewed May 17, 2023
View reviewed changes
core/templates/safe_refcount.h
#define SAFE_NUMERIC_TYPE_PUN_GUARANTEES(m_type) \
static_assert(sizeof(SafeNumeric<m_type>) == sizeof(m_type)); \
static_assert(alignof(SafeNumeric<m_type>) == alignof(m_type)); \
static_assert(std::is_trivially_destructible<std::atomic<m_type>>::value);
#define SAFE_FLAG_TYPE_PUN_GUARANTEES \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@akien-mga akien-mga merged commit d803304 into godotengine:master May 17, 2023
@akien-mga
Copy link
Member

Thanks!

@RandomShaper RandomShaper deleted the enh_fix_mt_proc branch May 17, 2023 15:18
@YuriSizov YuriSizov mentioned this pull request May 22, 2023
Closed
@kleonc kleonc mentioned this pull request Jul 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga left review comments

@reduz reduz reduz approved these changes

Assignees
No one assigned
Labels
bug enhancement performance topic:core
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
4 participants
@RandomShaper @akien-mga @reduz @Calinou