CI: Fix running the unit tests on windows #76887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI should be fixed by #76885, will have to be rebased when it is merged |
RedworkDE
force-pushed
the
ci-fix-windows-unit-tests
branch
from
975fe9e to
adbb323
Compare
akien-mga
approved these changes
May 15, 2023
|
Thanks! |
|
Cherry-picked for 4.0.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on #76878 I noticed that the unit tests don't appear to run correctly on the windows editor leg.
The issue most likely is that the shell continued with (terminating) the script before the commands / tests were finished because the executable is normally not using the console subsystem.
Draft because running the that build artifact locally fails the tests, but that is probably just the environment being wrong.The test run properly now and the output matches that of the macOS run (except that macOS has a few additional
+[NSString stringWithUTF8String:]: NULL cStringerrors and colors)