Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI doesn't catch unit test failure on Windows #56942

Closed
YuriSizov opened this issue Jan 19, 2022 · 4 comments
Closed

CI doesn't catch unit test failure on Windows #56942

YuriSizov opened this issue Jan 19, 2022 · 4 comments

Comments

@YuriSizov
Copy link
Contributor

Godot version

master

System information

GitHub Actions

Issue description

I've recently ran into issues with my PR that caused some unit test runs to fail on CI. I initially thought that the problem was localized to MacOS and Linux, but upon running tests locally on Windows I found out it was affected as well. However, on CI the tests either didn't run, or didn't report anything.

Mac: https://github.com/godotengine/godot/runs/4866470574?check_suite_focus=true
Linux: https://github.com/godotengine/godot/runs/4866474222?check_suite_focus=true
Windows: https://github.com/godotengine/godot/runs/4866470448?check_suite_focus=true

In case the links are no longer available, here's what it looks like for the mac, and here's what windows shows. Again, locally tests fail the same as they should on other platforms (running through Windows Terminal, so essentially in PowerShell).

Steps to reproduce

See above.

Minimal reproduction project

N/a

@brno32
Copy link
Contributor

brno32 commented Dec 5, 2023

is this still an issue? if so I could take a look

@YuriSizov
Copy link
Contributor Author

@brno32 Not sure, haven't looked into it in a while. Checking latest master builds I can see that tests do appear to be running on Windows just as well as on other platforms. So probably not an issue anymore. But would be nice to confirm. You can probably try to break the tests on purpose and then check in your fork what it looks like on CI.

@brno32
Copy link
Contributor

brno32 commented Dec 11, 2023

Confirmed it's not a problem. When tests fail on windows the pipeline turns red

brno32#2

https://github.com/brno32/godot/actions/runs/7174383686/job/19535732689?pr=2

@akien-mga
Copy link
Member

Probably fixed by #76887.

@akien-mga akien-mga added this to the 4.1 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants