Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing shader debug documentation #76885

Merged
merged 1 commit into from
May 9, 2023
Merged

Add missing shader debug documentation #76885

merged 1 commit into from
May 9, 2023

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented May 9, 2023 •
edited
Loading

Introduced by #73588, fixes CI

@AThousandShips AThousandShips requested a review from a team as a code owner May 9, 2023 19:04
@AThousandShips
Copy link
Member Author

Filling in these descriptions

clayjohn
clayjohn reviewed May 9, 2023
View reviewed changes
doc/classes/ProjectSettings.xml Show resolved Hide resolved
doc/classes/ProjectSettings.xml Show resolved Hide resolved
doc/classes/ProjectSettings.xml Show resolved Hide resolved
clayjohn
clayjohn approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I hope I didn't step on your toes, I started suggesting descriptions before your comment about filling in the descriptions haha!

@AThousandShips
Copy link
Member Author

Oh no worries! I didn't quite know what to fill into those and very appreciated

This was referenced May 9, 2023
Merged
Merged
Closed
Draft
Closed
@AThousandShips
Copy link
Member Author

Everything should be ready

@AThousandShips AThousandShips mentioned this pull request May 9, 2023
Merged
@Calinou Calinou added this to the 4.1 milestone May 9, 2023
@akien-mga akien-mga merged commit 7f46875 into godotengine:master May 9, 2023
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips deleted the doc_update branch May 10, 2023 05:19
@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
4 participants
@AThousandShips @akien-mga @clayjohn @Calinou