-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi window code and shader editors (GSOC'22 Project) #62378
Conversation
Looking good so far. As I mention in the other PR discussion: F1 is not working inside the code window while its focus |
882f18a
to
174039e
Compare
@jcostello sorry for the late response, but now global shortcuts (like F1 or Ctrl+S) should work in the script window too. |
Nice. Im out til the weekend. I will test it then :) |
9994552
to
3622226
Compare
b6c7fbe
to
7296303
Compare
35443f7
to
d73a49e
Compare
The PR is now feature complete for what I have planned. The only thing remaining to do are a bunch of editor settings to customize the behavior. Again, Happy testing! |
Could you please rebase this to the latest |
2697ed2
to
aa02bca
Compare
Ok now it uses regular Button and Popup, It should work for you now. |
This comment was marked as resolved.
This comment was marked as resolved.
b740649
to
bfb1a37
Compare
I can't reproduce it on Linux. Just in case, I forcefully hide the popup when the button is pressed.
After the rebase, the F1 shortcuts now work when docked and undocked.
Done. |
bfb1a37
to
d89f90d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All obvious/important issues are fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me from a cursory code check, and I tested the functionality a bit and it seems to work well.
I think it's time for a merge and get it tested more widely :)
For the record, I'll release 4.1-dev2 tomorrow but I already built it from a commit prior to merging this, so this will be in an official build in 4.1-dev3.
I noticed this warning in the terminal output (and in the editor toaster) while opening a project:
I previously ran into it with #76509 which was fixed by #76513. This PR might introduce another case of using the theme too early. As a side note, while testing this PR I saved a project with 2 floating docks, which were properly remembered across sessions. Then I reopened that same project in a Godot build from the |
d89f90d
to
590960a
Compare
So sad, users won't have this absolutely desired feature tomorrow, they would wait for other 2 weeks (sarcasm).
I tested myself and I don't really understand why it works. I guess the docks were placed in the default slot as a failsafe. |
CI should be fixed by #76885, will have to be rebased when it is merged |
590960a
to
b4d6b47
Compare
Congrats on landing this amazing feature! 🎉 |
This is the main PR for my GSOC'22 project (link to the project description).
Old commit history with expanded commits: https://github.com/trollodel/godot/tree/gsoc_2022_multiwindow_full_history
The project consists in the following major features:
You can read more about it in the GSOC'22 progress report: https://godotengine.org/article/gsoc-2022-progress-report-1
The PR is feature complete, further enhancement will be done in a separate PR, after the merge of this one, which will happen after the 4.0 release as marked by the milestone.
Screenshots/Videos
Peek.24-06-2022.12-06.mp4
Peek.15-07-2022.12-42.mp4
Peek.15-07-2022.13-39.mp4
Peek.19-07-2022.15-06.mp4
The screen selector in the Script Editor (two 1920x1080 screen)
The screen selector with different screen sizes (one 1920x1080 screen and one 1280x960 screen, 4:3 aspect ratio)
Everything undocked!
Part of godotengine/godot-proposals#28.
Happy testing!
Supersedes #62963.
Keywords for easy searching: detach script, detachable, detached, pop out, popping out, other window, separate window, undock, undocked, undockable, floating