Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Floating Script Editor Window #62373

Closed

Conversation

SirQuartz
Copy link
Contributor

@SirQuartz SirQuartz commented Jun 24, 2022

I've been working on a solution to make the script editor a floating window. This addresses godotengine/godot-proposals#28

Here's a working prototype:

Floating.Script.Window.mp4

It's not perfect, still has some bugs, but it works quite well nevertheless.

@SirQuartz SirQuartz requested a review from a team as a code owner June 24, 2022 09:04
@SirQuartz SirQuartz force-pushed the floating-script-editor branch from 55f8356 to e9e8e4a Compare June 24, 2022 09:08
I've been working on a solution to make the script editor a floating window.
@SirQuartz SirQuartz force-pushed the floating-script-editor branch from a82db84 to 7d28e5a Compare June 24, 2022 09:24
@YuriSizov YuriSizov marked this pull request as draft June 24, 2022 09:51
@YuriSizov YuriSizov added this to the 4.1 milestone Jun 24, 2022
@trollodel
Copy link
Contributor

Hi @SirQuartz, you may be happy to know that I'm already working to that as part of the GSOC'22 (link to the project).
I already start working to it here: https://github.com/trollodel/godot/tree/gsoc_2022_multiwindow.

@SirQuartz
Copy link
Contributor Author

Hi @SirQuartz, you may be happy to know that I'm already working to that as part of the GSOC'22 (link to the project).
I already start working to it here: https://github.com/trollodel/godot/tree/gsoc_2022_multiwindow.

Oh wow, I wasn't even aware of that, that looks way better than whatever I was trying to do!

@jcostello
Copy link
Contributor

I will check @trollodel implementation. How ever, yours or @trollodel should allow to have the code window and a viewport at the same time to allow multi monitor

@jcostello
Copy link
Contributor

jcostello commented Jun 24, 2022

I will check @trollodel implementation. How ever, yours or @trollodel should allow to have the code window and a viewport at the same time to allow multi monitor

@trollodel Niceeee

BTW. The floting window doens't allow for F1 while focus

Screenshot from 2022-06-24 10-10-28

@trollodel
Copy link
Contributor

trollodel commented Jun 24, 2022

Thanks @jcostello, but please don't go off-topic talking about my work, as this is someone else's PR.
I'll open a draft PR soon to allow discussion there.
EDIT: Here's the PR: #62378

@SirQuartz
Copy link
Contributor Author

I see no reason to continue working on this since @trollodel was already working on this and has a better solution.

@SirQuartz SirQuartz closed this Jun 24, 2022
@akien-mga akien-mga modified the milestones: 4.1, 4.0 Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants