Make dialogs exclusive by default, fixes #37732 #39993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix on set_visible, not creating exclusive children as it should.
akien-mga
approved these changes
Jun 30, 2020
3 tasks
|
Thanks! |
|
Dialogs work great again now thanks |
|
This causes a regression with single-window mode, none of the windows (nor the editor in the background) are clickable. The editor isn't frozen, it still updates when resized, but it no longer accepts user input. This is what happens when I open the editor settings to try and disable single window mode (and then I resized the window so you can see it's not frozen). For the moment it seems like I'm in a chicken-and-egg problem unless I delete my editor settings file.
|
|
Confirming - opening any dialogs on Fedora causes Editor basically to stop receiving any input :( |
akien-mga
reviewed
Jul 1, 2020
| @@ -44,6 +44,7 @@ class LineEdit; | |||
| class AcceptDialog : public Window { | |||
| GDCLASS(AcceptDialog, Window); | |||
|
|
|||
| public: | |||
This was referenced Jul 6, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix on set_visible, not creating exclusive children as it should.
The idea is that if you open a transient dialog (a dialog that is spawned from a parent window) by default you are not allowed to do changes in the parent window until this dialog is closed. Likewise, the dialog will not close if you focus in/out as it is now an exclusive dialog.
Bugsquad edit: Fixes #37732. Also fixes #37731 and fixes #37710