Fix popup closing when parent window is focused related issues. #39145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 tasks
|
Is not this long overdue being merged? I use a WM where the focus follows the mouse cursor, and the editor is completely unusable on any commit after 4758057, which introduced the issue, including current master (2760576). Does this pull request introduce other issues? Why should a window close just because the parent is focused? That is even more draconian than closing a popup because you clicked outside it. |
|
Superseded by #39993. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know this is just avoiding a bug but it fixes #37732, #37731 and #37401(part 3).
Possibly more.
Initially, I thought this behaviour change would be bad. But quite a few applications don't close popups when the parent is focused.
Some like Windows Explorer(explorer.exe) just focus parent while hiding the popup(eg, shift+delete; permanent file deletion confirmation popup) behind it(but they also let popup windows be independent windows).
Some like Firefox doesn't let the user interact with the parent window till popup is closed(eg, file upload popup, close multiple tab popup, etc.).