Fixes the right and center alignment bug of rich text label #39164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
the
cherrypick:3.x
|
Great job! This PR also fixes #34308. I've tested different cases with left/center/right align, some images and different fonts and everything works fine so far. |
theoway
force-pushed
the
richlabeltext_align_bug
branch
from
b6e6eee to
fa506bd
Compare
Thanks for running the tests. |
theoway
force-pushed
the
richlabeltext_align_bug
branch
2 times, most recently
from
bddb0a8 to
a7d2d6e
Compare
akien-mga
reviewed
Jun 3, 2020
theoway
force-pushed
the
richlabeltext_align_bug
branch
from
a7d2d6e to
b2a32d0
Compare
|
Thanks! |
|
Cherry-picked for 3.2.2. |
akien-mga
removed
the
cherrypick:3.x
pouleyKetchoupp
added a commit
to nekomatata/godot
that referenced
this pull request
Jul 3, 2020
Fixes godotengine#40068 (regression from godotengine#39164) by not applying the line offset change in the case of fill alignment mode.
akien-mga
pushed a commit
to akien-mga/godot
that referenced
this pull request
Jul 3, 2020
Fixes godotengine#40068 (regression from godotengine#39164) by not applying the line offset change in the case of fill alignment mode. (cherry picked from commit 44f8899)
pouleyKetchoupp
added a commit
to nekomatata/godot
that referenced
this pull request
Sep 11, 2020
Fixes godotengine#41006 (regression from godotengine#39164). The original alignment fix was limited to PROCESS_DRAW mode, which caused some discrepancies with PROCESS_POINTER mode. Now only PROCESS_CACHE is excluded with a condition a few lines above.
MarcusElg
pushed a commit
to MarcusElg/godot
that referenced
this pull request
Oct 19, 2020
Fixes godotengine#40068 (regression from godotengine#39164) by not applying the line offset change in the case of fill alignment mode.
MarcusElg
pushed a commit
to MarcusElg/godot
that referenced
this pull request
Oct 19, 2020
Fixes godotengine#41006 (regression from godotengine#39164). The original alignment fix was limited to PROCESS_DRAW mode, which caused some discrepancies with PROCESS_POINTER mode. Now only PROCESS_CACHE is excluded with a condition a few lines above.
huhund
pushed a commit
to huhund/godot
that referenced
this pull request
Nov 10, 2020
Fixes godotengine#40068 (regression from godotengine#39164) by not applying the line offset change in the case of fill alignment mode. (cherry picked from commit 44f8899)
huhund
pushed a commit
to huhund/godot
that referenced
this pull request
Nov 10, 2020
Fixes godotengine#41006 (regression from godotengine#39164). The original alignment fix was limited to PROCESS_DRAW mode, which caused some discrepancies with PROCESS_POINTER mode. Now only PROCESS_CACHE is excluded with a condition a few lines above. (cherry picked from commit b783fa1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38846
Bug:-
[right]and[center]alignment tags of BBCode in RichTextLabel were not aligning properly like they were supposed to, and the text would overlap when the label was resized.Reason:- Offset cache of the lines was not getting updated.
I've used center alignment for demonstration.
Before the fix:-
After the fix:-
