Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.2.1 => 3.2.2 - degradation of the RichTextLabel (tag [fill]) #40068

Closed
Tracked by #39144
DimitriyPS opened this issue Jul 2, 2020 · 3 comments · Fixed by #40081
Closed
Tracked by #39144

3.2.1 => 3.2.2 - degradation of the RichTextLabel (tag [fill]) #40068

DimitriyPS opened this issue Jul 2, 2020 · 3 comments · Fixed by #40081
Labels
bug regression topic:gui
Milestone
3.2

Comments

@DimitriyPS
Copy link

Godot version:
3.2.2

OS/device including version:
All

Issue description:
And again ... again ... as always ... RichTextLabel is a disaster!
I updated Godot to version 3.2.2, after which the display of text in RichTextLabel everywhere broke in my project. Instead of justification (tag [fill]), chaotic artifacts are observed at the beginning and end of lines.

00000
@bruvzg
Copy link
Member

bruvzg commented Jul 2, 2020

Regression form #39164

@akien-mga
Copy link
Member

CC @theoway @pouleyKetchoupp

@akien-mga akien-mga added this to the 3.2 milestone Jul 2, 2020
@HaSa1002 HaSa1002 mentioned this issue Jul 2, 2020
Open
@pouleyKetchoupp
Copy link
Contributor

My bad, I forgot to check fill alignment mode when testing #39164.

I'm preparing a quick fix to avoid changing the line offset with fill alignment, so we get back to the state it was in 3.2.1 for this case.

pouleyKetchoupp added a commit to nekomatata/godot that referenced this issue Jul 3, 2020
@pouleyKetchoupp
Fix RichTextLabel fill alignment regression
44f8899 
Fixes godotengine#40068 (regression from godotengine#39164) by not applying the line offset
change in the case of fill alignment mode.
@pouleyKetchoupp pouleyKetchoupp mentioned this issue Jul 3, 2020
Merged
akien-mga pushed a commit to akien-mga/godot that referenced this issue Jul 3, 2020
@pouleyKetchoupp @akien-mga
Fix RichTextLabel fill alignment regression
d6b2330 
Fixes godotengine#40068 (regression from godotengine#39164) by not applying the line offset
change in the case of fill alignment mode.

(cherry picked from commit 44f8899)
MarcusElg pushed a commit to MarcusElg/godot that referenced this issue Oct 19, 2020
@pouleyKetchoupp @MarcusElg
Fix RichTextLabel fill alignment regression
781b724 
Fixes godotengine#40068 (regression from godotengine#39164) by not applying the line offset
change in the case of fill alignment mode.
huhund pushed a commit to huhund/godot that referenced this issue Nov 10, 2020
@pouleyKetchoupp
Fix RichTextLabel fill alignment regression
db9b67c 
Fixes godotengine#40068 (regression from godotengine#39164) by not applying the line offset
change in the case of fill alignment mode.

(cherry picked from commit 44f8899)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug regression topic:gui
Projects
None yet
Milestone
3.2
Development

Successfully merging a pull request may close this issue.

Fix RichTextLabel fill alignment regression nekomatata/godot
5 participants
@pouleyKetchoupp @Chaosus @akien-mga @bruvzg @DimitriyPS