-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RichTextLabel's [center] and [right] are still broken #34308
Comments
If I try to nuke it and rewrite it, do we care about backwards compatibility? Or should I just try to patch it here and there UwU? |
@Nolkaloid I think for 4.0, there are already lots of changes to break compatibility. But for 3.2, patches should be better. |
Godot 3.2 still has problems with wrapping centered text, including this weird edge-case where it overlaps itself. The RichTextArea is tall enough to accommodate four rows of text, and additional rows cause a scroll bar. But, sometimes the textarea will just plop a word on top of other words. |
Can we close this if it's fixed by #39164? |
This bug was confirmed to be fixed by @pouleyKetchoupp in #39164 (comment), closing. |
Godot version:
269145a
OS/device including version:
ArcoLinux
Issue description:
There seems to be a misconception in what's expected of RichTextLabel's [center] and [right] tags. When the user attempts to center-align their text, for example, what they're looking for is precisely what Godot's label does:
This expectation is also supported by this BBCode tester https://infinite-story.com/tools/bbcode.php
When the RTL centers text, however, it winds up looking like this:
It centers the entire block of text to the middle of the control, but doesn't actually center-align. The user wants to center-align, not center the entire contents.
[right] also suffers this same issue:
For contrast, here's what the BBCode tester outputs:
According to #29785 , #6982 is fixed, but it seems to fix a problem that doesn't actually exist, or missed the point of the issue being raised. The tags are expected to center-align and right-align the text itself, just like Label, and just like the BBCode tester, not shift the entire contents towards the center or the right while keeping the text alignment left.
The text was updated successfully, but these errors were encountered: