-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better file dialogue #36053
Better file dialogue #36053
Conversation
Thanks for working on this, it will be much appreciated 🙂 I noticed dates on the screenshot aren't padded; you can use |
It would be nice to have those enhancements in the |
Thanks ill try to impliment it. Lastly, what do you think about having adjustable column's size? Like Split container |
I guess this would have to be implemented in Tree, but it's a pretty complex class already. |
6b2e3f7
to
fad88e1
Compare
Pull request is ready for merge |
fad88e1
to
def5d87
Compare
} | ||
|
||
FileAccess::FileSize FileAccess::get_size_simplified(const String &p_file) { | ||
Dictionary dic = get_sizes(p_file); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allocating a dictionary containing several multiples of of the same original size only to return it as a one size sounds a bit wasteful, also no other code seems to use it anyways. Just compute this in the same function without intermediary.
The Haiku port now resides at: https://github.com/godotengine/godot-haiku-platform While we're happy to support as many Free and Open Source platforms as we can, we need to put the main focus on the platforms that we can reasonably maintain, and for Haiku we have been lacking maintainers ever since the port was first merged in 2015. The Haiku code has not been compiling and much less working at least since the release of Godot 3.0, and while some attempts have been made at fixing things, it's still not functional today in the `3.2` branch (and much less in `master`, understandably). Having it in an external repository should hopefully enable Haiku contributors to fix issues in their own time, and possibly tag versions compatible with past Godot releases once they are ready. (cherry picked from commit efcc508)
(cherry picked from commit 08577fa)
See godotengine#39731. (cherry picked from commit 227f124)
Co-authored-by: Aaron Franke <[email protected]> (cherry picked from commit 29e901c)
…e in dynamic contexts" This reverts commit 42a3150. It breaks compat as is and needs some further work before it can be cherry-picked for 3.2.x.
(cherry picked from commit a94ba7b)
…stringify Fix for a crash on printing freed object
This reverts commit 7f61710. See godotengine#38868, in its current implementation a small skew value might end up serialized to scene files due to floating point precision errors, which is detrimental to VCS. This can be cherry-picked anew once a fix for godotengine#38868 has been found.
This is now available in a separate repository at https://github.com/godotengine/godot-google-play-billing
(cherry picked from commit 8b0232b)
…playShowCursor. (cherry picked from commit 7a250b5)
Prevent the gizmo distance from being zero by MAX-ing it with CMP_EPSILON (cherry picked from commit ed2bbdb)
…payment-plugin Remove GodotPayment android plugin (3.2)
…e changes, ensure mouse_mode is set before `cursor_set_shape` is called to restore cursor. (cherry picked from commit fc1d1c3)
(cherry picked from commit 439c97e)
def5d87
to
02fae0f
Compare
@ShlomiRex you gotta rebase this... |
@ShlomiRex It seems that you rebased incorrectly. Please read this documentation article for more information: https://docs.godotengine.org/en/latest/community/contributing/pr_workflow.html Alternatively, if you want to use a GUI, watch this video: https://www.youtube.com/watch?v=0XKy8YpP5Ww |
This branch is for making file dialogue like file explorer, with Last modified and Size of files and folders and user can sort by those columns, support for diffirent column placement (last modified can be first column, etc..)
Source branch:
master
Bugs to fix:
When selecting an already selected row, it deselects it. Note: Issue #36047Features to implement:
Instead of tree title being just a string, turn it to button so when it is clicked, file dialogue will sort the entries by that column.Currently it is very complex maybe in the futureAdd more rich Date options, like date formats and such. Instead of using _OS singleton to get date you can use Date Object.People don't like this feature, also it should be other pull request, unrelated to UIColumns's width should change like when using SliderContainerLike the first, it is very complex, maybe in the future it will be availableIssues closed: