Fix #36047 - No deselect on already selected row when selection mode set to SELECT_ROW #36094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShlomiRex
changed the title
|
PRs should be made against the Please squash commits together and amend the commit log to be meaningful, "Fix" isn't. See https://github.com/godotengine/godot/blob/master/CONTRIBUTING.md#format-your-commit-logs-with-readability-in-mind |
it no longer de-selects an already selected row if the SELECT_MODE is set to SELECT_ROW.
ShlomiRex
force-pushed
the
tree-fix-selectionmode-row
branch
from
15fa907 to
f1cdeac
Compare
Ok sir I did it. Now I know that I need to pull request against master and not the latest branch. :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36047
I checked and it worked, it no longer de-selects an already selected row if the SELECT_MODE is set to SELECT_ROW.
How can I test this? I manually tested this but I think there are some edge cases or something.