Fix crash on save-branch-as-scene #15571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess we could do byte tagging, the problem is that as far as I know, it depends on OS (windows does byte tagging on debug too) so it should be optional by OS? |
|
The advantage of a custom approach would be that depending on the state of the memory you can tag it differently: released, just allocated, just freed after a realloc, just allocated by a realloc. |
|
lets add it after 3.0 is out then
…On Thu, Jan 11, 2018 at 1:24 PM, Pedro J. Estébanez < ***@***.***> wrote:
The advantage of a custom approach would be that depending on the state of
the memory you can tag it differently: released, just allocated, just freed
after a realloc, just allocated by a realloc.
I think I helps a lot in debugging. When I saw 0xea in the stack trace of
this bug for 2.1 I immediately knew it was accesing a dangling pointer.
When I have enough time I'll submit a PR and we will be able to continue
discussion there.
Will be optional and only for debug builds, of course.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#15571 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AF-Z29qWVr41M7u_4TTj2Kdp9eoe1abAks5tJjW5gaJpZM4RZ5Dm>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15539.
Fixes #9367.
These reports were made for 2.1, because original reporters weren't able to reproduce it on 3.0.
The truth is that given that 3.0 performs no byte-tagging on released memory, accessing a dangling object can be unnoticed. In this case. the crashing code would get the illusion that the signal map was just empty but valid, albeit actually the whole object had been released.
@reduz, maybe you can change your mind about byte-tagging on memory release for debug builds.