Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

color picker doesn't display colors properly #8372

Closed
nunodonato opened this issue Apr 12, 2017 · 12 comments
Closed

color picker doesn't display colors properly #8372

nunodonato opened this issue Apr 12, 2017 · 12 comments

Comments

@nunodonato
Copy link
Contributor

Operating system or device - Godot version: Linux, 3.0master

Issue description:
The color picker used in the inspector (and probably other places) is not showing the color selection rectangle.

Besides that, the hue selection (vertical bar) seems to have a different offset than the real color being selected. One of them appears to be the inverted value of the other.

@Shockblast
Copy link
Contributor

It happens to me the same in windows, when I change the "color" (modulate?) of the sprites for example.

@alex9099
Copy link

Same here just a empty square with no colors, when clicking in that square the color is picked but there is no color on the square
image

@akien-mga akien-mga added this to the 3.0 milestone Apr 12, 2017
@avril-gh
Copy link
Contributor

same as @alex9099
tested under windows 7 32 bit

@eon-s
Copy link
Contributor

eon-s commented Apr 12, 2017

All the time since the first buildable godot 3, also the invisible part of the color picker seems to be inverted respecting to the right bar (like, pink is yellow and yellow is pink).

@Gibbz
Copy link

Gibbz commented Apr 13, 2017

yep same issue here for the color picker

@MarianoGnu
Copy link
Contributor

This should fix ColorPicker and Polygon2D for now, but i believe some more fixes will be needed for other nodes like CollisionPolygon wich is not drawing neighter.

@akien-mga akien-mga changed the title [3.0] color picker doesn't display colors properly color picker doesn't display colors properly May 18, 2017
@remorse107
Copy link
Contributor

The palette to the right is flipped upside down. Not a big deal as the mouse coordinate logic is just a simple flip and all is good.

But the Polygon2D doesn't seem to work in Godot 3 at the moment. Which is okay, because I ran the Polygon2D code in Godot 2 where it is working and the palette picker does not look good at all.

I have it nearly corrected, but I think that a fragment shader is the better solution to this versus a Polygon2D.

capture

@toger5
Copy link
Contributor

toger5 commented Jun 15, 2017

@remorse107 pull the newest master. the draw polygon got finally fixed today

@remorse107
Copy link
Contributor

Okay. I pulled from the Master, and now it looks really good. I guess I'll make a push request which I've never done before.

capture

@MarianoGnu
Copy link
Contributor

reduz recently fixed _draw_polygon function, wich was in charge of drawing the color picker, i did a fix long ago to replace shaders for polygons

@remorse107
Copy link
Contributor

remorse107 commented Jun 15, 2017 via email

@akien-mga
Copy link
Member

Fixed by #9192.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests