Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement albanian (sq-AL) localization #324

Closed
goatshriek opened this issue Jan 5, 2023 · 6 comments
Closed

implement albanian (sq-AL) localization #324

goatshriek opened this issue Jan 5, 2023 · 6 comments
Labels
good first issue something that would be simple for a newcomer to stumpless to work on help wanted external contributations encouraged l10n localization of stumpless low code work that requires little to no coding proficiency

Comments

@goatshriek
Copy link
Owner

There is a detailed guide on how to go about adding a new language in the localization documentation.

If you'd like a concrete example of such a change, check out commit 5529e07, which shows how to update the various build and header files outlined in the documentation.

@goatshriek goatshriek added help wanted external contributations encouraged l10n localization of stumpless low code work that requires little to no coding proficiency labels Jan 5, 2023
@goatshriek goatshriek added the good first issue something that would be simple for a newcomer to stumpless to work on label Aug 24, 2023
@heavylemon1
Copy link
Contributor

Hello @goatshriek! 👋
New to the project here, while looking at the localization discussion, I noticed that
someone mentioned adding localization for Albanian.
Since I speak Albanian, I would also like to contribute if there's room for contributing on this part.
If not, that's completely understandable from my side.

Thanks!

@goatshriek
Copy link
Owner Author

Absolutely, the contribution would be welcome!

I do recommend that you wait a few days before beginning though - I'm very close to finishing SQLite support, which includes a number of new localized strings. It would be ideal for you to add translations after that, so that the new localization is not immediately missing strings after the addition. I'll update this issue once I have that merged into the default branch, if that's okay with you.

@heavylemon1
Copy link
Contributor

Thanks @goatshriek !
Makes sense, completely understandable from my side.
I'll be watching this and the moment that the SQLite support is ready, I will start adding the localization's.
In the meantime I noticed that someone did mention that they wanted to assist on AL localization.
I want to work on this and if someone also wants to collaborate with me on this, they are welcomed on my side 😃

@goatshriek
Copy link
Owner Author

SQLite support has been merged in via #393, so you're good to go on this! I look forward to seeing your contribution!

@heavylemon1
Copy link
Contributor

Great @goatshriek, will be starting working on this from tomorrow (Monday).
Thanks for letting me know!

heavylemon1 added a commit to heavylemon1/stumpless that referenced this issue Dec 12, 2023
@heavylemon1
Copy link
Contributor

Hey @goatshriek !
Just wanted to let you know that I just opened PR #395 where I added the localization for Albanian.
Thanks!

heavylemon1 added a commit to heavylemon1/stumpless that referenced this issue Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue something that would be simple for a newcomer to stumpless to work on help wanted external contributations encouraged l10n localization of stumpless low code work that requires little to no coding proficiency
Projects
None yet
Development

No branches or pull requests

2 participants