Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sqlite3 targets #393

Merged
merged 89 commits into from
Dec 10, 2023
Merged

add sqlite3 targets #393

merged 89 commits into from
Dec 10, 2023

Conversation

goatshriek
Copy link
Owner

Adds SQLite3 targets for logging to a SQLite database.

The indent wrapper script has been removed as part of this change, as some of the formatting that it enforces is undesirable. Specifically, the indention of #define statements within header guards, and function calls with no parameters having two spaces inside will no longer be used in new code moving forward.

@goatshriek goatshriek added the enhancement new features or improvements label Dec 10, 2023
@goatshriek goatshriek self-assigned this Dec 10, 2023
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

Attention: 86 lines in your changes are missing coverage. Please review.

Comparison is base (c2cb789) 91.79% compared to head (10a1620) 90.48%.

Files Patch % Lines
src/target/sqlite3.c 74.77% 55 Missing and 28 partials ⚠️
src/error.c 66.66% 2 Missing ⚠️
src/strbuilder.c 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           latest     #393      +/-   ##
==========================================
- Coverage   91.79%   90.48%   -1.31%     
==========================================
  Files          44       46       +2     
  Lines        3776     4160     +384     
  Branches      497      553      +56     
==========================================
+ Hits         3466     3764     +298     
- Misses        216      273      +57     
- Partials       94      123      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Dec 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@goatshriek goatshriek merged commit 89fcee4 into latest Dec 10, 2023
77 of 79 checks passed
@goatshriek goatshriek deleted the sqlite branch December 10, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new features or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant