Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI should detect problems in PRs, not after merging #2531

Closed
moul opened this issue Jul 7, 2024 · 2 comments
Closed

CI should detect problems in PRs, not after merging #2531

moul opened this issue Jul 7, 2024 · 2 comments
Labels
🐞 bug Something isn't working 🗺️good first issue🗺️ Ideal for newcomer contributors

Comments

@moul
Copy link
Member

moul commented Jul 7, 2024

We had at least 3 merged pull requests in the last few days (two of them were mine, sorry), and they were green while still unmerged, but they caused the master branch to become red.

We need to fine-tune the CI to prevent this from happening.
@moul moul added the 🐞 bug Something isn't working label Jul 7, 2024
@moul moul added the 🗺️good first issue🗺️ Ideal for newcomer contributors label Jul 7, 2024
@thehowl
Copy link
Member

thehowl commented Jul 8, 2024

The case I saw today was caused by a PR in examples/, changing the behaviour of a test in gno.land/ (a txtar test).

I'm starting to think we should just test everything all the time, also on PRs.

@moul moul mentioned this issue Jul 14, 2024
Merged
7 tasks
moul added a commit that referenced this issue Jul 14, 2024
@moul
chore: trigger gnoland CI when updating examples/
30c752a 
Addresses #2531
@moul moul mentioned this issue Jul 14, 2024
Merged
thehowl pushed a commit that referenced this issue Jul 14, 2024
@moul
ci: trigger gnoland workflow when updating examples/ (#2588)
fadf622 
Addresses #2531
gfanton pushed a commit to gfanton/gno that referenced this issue Jul 23, 2024
@moul @gfanton
ci: trigger gnoland workflow when updating examples/ (gnolang#2588)
2d6ed7d 
Addresses gnolang#2531
@thehowl thehowl mentioned this issue Jul 24, 2024
Merged
thehowl added a commit that referenced this issue Jul 24, 2024
@thehowl
ci: fix broken CI, always test all go code (#2625)
0e3c050 
There's been another CI fail on master just now, because changes in
examples/ were changing the golden output in gnovm/, but gnovm/ was not
tested.

This PR implements the suggestion I made in #2531 - ie. not
discriminating CIs based on the paths of the modified file.
@thehowl
Copy link
Member

thehowl commented Jul 24, 2024

Done with #2625

@thehowl thehowl closed this as completed Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug Something isn't working 🗺️good first issue🗺️ Ideal for newcomer contributors
Projects
🧙‍♂️gno.land core team
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moul @thehowl