Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix broken CI, always test all go code #2625

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Jul 24, 2024

There's been another CI fail on master just now, because changes in examples/ were changing the golden output in gnovm/, but gnovm/ was not tested.

This PR implements the suggestion I made in #2531 - ie. not discriminating CIs based on the paths of the modified file.

@thehowl thehowl self-assigned this Jul 24, 2024
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.99%. Comparing base (8865638) to head (b69e5cc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2625      +/-   ##
==========================================
- Coverage   55.00%   54.99%   -0.01%     
==========================================
  Files         595      595              
  Lines       79775    79775              
==========================================
- Hits        43879    43874       -5     
- Misses      32576    32581       +5     
  Partials     3320     3320              
Flag Coverage Δ
contribs/gnodev 25.65% <ø> (-0.35%) ⬇️
contribs/gnofaucet 14.46% <ø> (ø)
contribs/gnokeykc 0.00% <ø> (ø)
contribs/gnomd 0.00% <ø> (ø)
gno.land 64.15% <ø> (ø)
gnovm 60.20% <ø> (ø)
misc/autocounterd 0.00% <ø> (ø)
misc/genproto 0.00% <ø> (ø)
misc/genstd 80.54% <ø> (ø)
misc/goscan 0.00% <ø> (ø)
misc/logos 17.38% <ø> (-0.31%) ⬇️
misc/loop 0.00% <ø> (ø)
tm2 54.45% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehowl thehowl merged commit 0e3c050 into master Jul 24, 2024
117 checks passed
@thehowl thehowl deleted the dev/morgan/no-separate-cis branch July 24, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants