Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testdata): wrong expectation at gnoweb_airgapped.txtar #2582

Merged
merged 3 commits into from
Jul 14, 2024

Conversation

linhpn99
Copy link
Contributor

@linhpn99 linhpn99 commented Jul 14, 2024

This caused a CI failure on the latest commit on the master branch : https://github.com/gnolang/gno/actions/runs/9925367874/job/27417714921

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@linhpn99 linhpn99 requested review from zivkovicmilos and a team as code owners July 14, 2024 06:24
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Jul 14, 2024
Copy link

codecov bot commented Jul 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.02%. Comparing base (36cf380) to head (6369d44).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2582   +/-   ##
=======================================
  Coverage   55.02%   55.02%           
=======================================
  Files         595      595           
  Lines       79662    79662           
=======================================
  Hits        43836    43836           
  Misses      32511    32511           
  Partials     3315     3315           
Flag Coverage Δ
contribs/gnodev 26.00% <ø> (ø)
contribs/gnofaucet 15.31% <ø> (ø)
contribs/gnokeykc 0.00% <ø> (ø)
contribs/gnomd 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moul
Copy link
Member

moul commented Jul 14, 2024

@linhpn99, if you want to help prevent further CI breakages, feel free to assist us in restoring the CI testing functionality. See issue #2531.

@moul moul enabled auto-merge (squash) July 14, 2024 11:41
@moul moul merged commit 54260d9 into gnolang:master Jul 14, 2024
78 of 79 checks passed
@linhpn99 linhpn99 deleted the fix/gnoweb_airgapped_test branch July 14, 2024 11:43
gfanton pushed a commit to gfanton/gno that referenced this pull request Jul 23, 2024
)

This caused a CI failure on the latest commit on the master branch :
https://github.com/gnolang/gno/actions/runs/9925367874/job/27417714921

<!-- please provide a detailed description of the changes made in this
pull request. -->

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>

---------

Co-authored-by: Manfred Touron <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants