Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-226: pre-commit's mirror of prettier is obsolete #247

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

Saransh-cpp
Copy link
Member

pre-commit's mirror of prettier was archived a few months back -

archived

prettier made some changes that breaks plugins entirely

Scientific Python recommends using https://github.com/rbubley/mirrors-prettier?tab=readme-ov-file now.

Refs: #226

@Saransh-cpp Saransh-cpp added the maintenance Maintenance: refactoring, typos, etc. label Sep 18, 2024
@Saransh-cpp Saransh-cpp changed the title gh-226: pre-commit's mirror of prettier is obselete gh-226: pre-commit's mirror of prettier is obsolete Sep 18, 2024
Copy link
Member

@paddyroddy paddyroddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay cool, I was aware it was archived, :/ good to know Scientific Python have a recommendation. Wasn't aware of that - there have been many made since.

@paddyroddy paddyroddy merged commit 30f86a6 into main Sep 18, 2024
10 checks passed
@paddyroddy paddyroddy deleted the saransh/fix-prettier branch September 18, 2024 16:16
@Saransh-cpp Saransh-cpp self-assigned this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance: refactoring, typos, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants