Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prettier for non-Python files #226

Closed
paddyroddy opened this issue Sep 17, 2024 · 0 comments · Fixed by #227
Closed

Add prettier for non-Python files #226

paddyroddy opened this issue Sep 17, 2024 · 0 comments · Fixed by #227
Assignees
@paddyroddy
Labels
enhancement New feature or request

Comments

@paddyroddy
Copy link
Member

Is Your Feature Request Related to a Problem? Please Describe

Add https://prettier.io which is a great code formatter for a variety of config options. Allows for consistency everywhere, streamlining PRs

Describe the Solution You'd Like

No response

Describe Alternatives You've Considered

No response

Additional Context

No response
@paddyroddy paddyroddy added the enhancement New feature or request label Sep 17, 2024
@paddyroddy paddyroddy self-assigned this Sep 17, 2024
@paddyroddy paddyroddy mentioned this issue Sep 17, 2024
Merged
Saransh-cpp added a commit that referenced this issue Sep 18, 2024
@Saransh-cpp
gh-226: pre-commit's mirror of prettier is obselete
cc254ce
@Saransh-cpp Saransh-cpp mentioned this issue Sep 18, 2024
Merged
paddyroddy pushed a commit that referenced this issue Sep 18, 2024
@Saransh-cpp
gh-226: pre-commit's mirror of prettier is obsolete (#247)
30f86a6 
[pre-commit's mirror of
prettier](https://github.com/pre-commit/mirrors-prettier) was
[archived](https://github.com/pre-commit/mirrors-prettier?tab=readme-ov-file#archived)
a few months back -

> # archived
>
> prettier made some changes that breaks plugins entirely

Scientific Python recommends using
https://github.com/rbubley/mirrors-prettier?tab=readme-ov-file now.

Refs: #226
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paddyroddy paddyroddy

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-226: run prettier over the repo via a pre-commit hook glass-dev/glass
1 participant
@paddyroddy