[ws-manager-bridge] Skip stale prebuild events #9191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 67ad495.
geropl
approved these changes
Apr 11, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 67ad495.
Description
Metrics show that we receive stale prebuild events when handling WorkspaceStatus updates on
ws-manager-bridge. This change skips events which are stale.Related Issue(s)
Fixes #9107
How to test
Requires a degree of luck, as it depends on event ordering on the message bus, but:
Start a prebuild
port-forward ws-manager-bridge on port 9500 and fetch metrics with curl localhost:9500/metrics
Check metrics contain gitpod_ws_manager_bridge_stale_prebuild_events_total with a positive count
Check ws-manager-bridge logs contain Stale prebuild event received, skipping.
Release Notes
Documentation
NONE