[db] Add transformer to map MySQL BIGINT to Number, use for Prebuild.statusVersion #9152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
force-pushed
the
mp/status-version-string
branch
3 times, most recently
from
5c5f50c to
51a700e
Compare
easyCZ
force-pushed
the
mp/status-version-string
branch
from
51a700e to
befb7b4
Compare
geropl
reviewed
Apr 6, 2022
| @@ -73,6 +73,7 @@ export class DBPrebuiltWorkspace implements PrebuiltWorkspace { | |||
| // statusVersion must only be set by controller/observer. | |||
| @Column({ | |||
| default: 0, | |||
| type: "bigint", | |||
There was a problem hiding this comment.
@easyCZ we could leave it an bigint/number and use a transformer to do the conversion from/to DB. see transformers.ts (or typeorm.ts? 🤔 )
There was a problem hiding this comment.
That's a great idea! Let me give that a go.
There was a problem hiding this comment.
This worked! Thanks a lot for suggesting it, I really wasn't happy with the solution I had originally.
|
/werft run with-clean-slate=true 👍 started the job as gitpod-build-mp-status-version-string.6 |
|
/werft run with-clean-slate=true 👍 started the job as gitpod-build-mp-status-version-string.8 |
easyCZ
changed the title
easyCZ
force-pushed
the
mp/status-version-string
branch
from
796bd32 to
4dd1e4c
Compare
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MySQL serializes the BIGINT type as a string, and without an explicit setting in TypeORM (on global level), it is retrieved as a string.
This PR adds a transformer which converts the retrieved BIGINT as string into a number on the underlying DB object representation.
Before
{ "component": "ws-manager-bridge", "severity": "INFO", "time": "2022-04-06T13:39:42.867Z", "message": "Found prebuild record in database.", "payload": { "id": "f42f95e7-7c96-4fc4-9513-e1171b84d176", "cloneURL": "https://gitlab.com/gitpod-milan/gitpod-large-image.git", "commit": "d741ef690a211f5a4157f3edc685c984b3b4b1d1", "projectId": "46fb2b28-9a46-4c4b-8d3b-a51125edb690", "branch": "main", "state": "building", "creationTime": "2022-04-06T13:39:39.000Z", "buildWorkspaceId": "gitpodmilan-gitpodlargei-32ivsk09l19", "statusVersion": "108085404106752" } }After
{ "component": "ws-manager-bridge", "severity": "INFO", "time": "2022-04-06T19:54:37.689Z", "message": "Found prebuild record in database.", "payload": { "id": "9a78ec6d-cc5e-4b32-be92-2243a4cb05a3", "cloneURL": "https://gitlab.com/gitpod-milan/gitpod-large-image.git", "commit": "753d6ee903d63c3707714f7ba79f3a5aa9705830", "projectId": "3602dab2-5849-4e86-b17c-2038b47bc225", "branch": "pass", "state": "building", "creationTime": "2022-04-06T19:54:32.000Z", "buildWorkspaceId": "gitpodmilan-gitpodlargei-p25esupv5zm", "statusVersion": 108086878208000 } }How to test
"message": "Found prebuild record in database.",, observe thestatusVersionis a number, rather than a string.Release Notes
Documentation
/uncc
/hold