[ws-manager-bridge] Skip stale prebuild events #9116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
force-pushed
the
mp/prebuild-state-set-version
branch
2 times, most recently
from
894c265 to
92dbc78
Compare
easyCZ
force-pushed
the
mp/prebuild-skip-stale-events
branch
from
51d261f to
5600e68
Compare
easyCZ
commented
Apr 5, 2022
Comment on lines
68
to
72
| // We've gotten an event which is younger than one we've already processed. We shouldn't process the stale one. | ||
| span.setTag("updatePrebuiltWorkspace.staleEvent", true); | ||
| this.prometheusExporter.recordStalePrebuildEvent(); | ||
| return; |
There was a problem hiding this comment.
This is the only real logic change, rest is formatting from prettier.
easyCZ
force-pushed
the
mp/prebuild-skip-stale-events
branch
from
5600e68 to
b477b15
Compare
|
Thanks for the review @AlexTugarev! /unhold |
This was referenced Apr 6, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not process stale WorkspaceStatus events when updating prebuilds.
Metrics show that we receive stale events relatively frequently on staging.
This change will result in increased accuracy of our prebuild status.
Related Issue(s)
Relates to:
Fixes
How to test
Requires a degree of luck, as it depends on event ordering on the message bus, but:
curl localhost:9500/metricsgitpod_ws_manager_bridge_stale_prebuild_events_totalwith a positive countws-manager-bridgelogs containStale prebuild event received, skipping.Release Notes
/hold