[installer] Disable definitely-gp by default
#9094
Conversation
Pothulapati
changed the title
definitely-gp by defaultdefinitely-gp by default
Pothulapati
force-pushed
the
tar/disable-definitely-gp
branch
from
f1e6626 to
22fceaf
Compare
|
/werft run with-clean-slate-deployment |
Pothulapati
force-pushed
the
tar/disable-definitely-gp
branch
2 times, most recently
from
4adac94 to
63c3969
Compare
|
Was able to verify that after this change, Open Vue Workspace on preview branch runs With this change, preview environments will not be using Will mark the PR ready for review, once I also verify the same for prod! |
|
@Pothulapati We should also adjust:
|
Fixes #8740 `definitely-gp` is being deprecated soon, and hence it is important to be disabled by default. Once it is fully deprecated, even this option has to be removed. For now, The following changes have been made: - Update the `definitelyGpDisabled` option to be true, Thus disabling it by default both in the `installer` and `chart`. - Update the airgap docs to remove a mention of this. Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
force-pushed
the
tar/disable-definitely-gp
branch
from
63c3969 to
7fe9318
Compare
|
/hold until https://github.com/gitpod-io/ops/pull/1741 is merged! :) |
| @@ -300,7 +300,7 @@ components: | |||
| minAgePrebuildDays: 7 | |||
| contentRetentionPeriodDays: 21 | |||
| contentChunkLimit: 1000 | |||
| definitelyGpDisabled: "false" | |||
| definitelyGpDisabled: true | |||
There was a problem hiding this comment.
Is this ok changing the type from a string to a boolean?
There was a problem hiding this comment.
Yep, can confirm that we aren't using it anywhere to toggle something, but just passing it down into the server-configmap, and follow the same pattern there like other boolean values (soemthing like enableLocalApp)
Description
definitely-gpis being deprecated soon, and henceit is important to be disabled by default. Once it
is fully deprecated, even this option has to be removed.
For now, The following changes have been made:
definitelyGpDisabledoption to be true, Thusdisabling it by default
Signed-off-by: Tarun Pothulapati [email protected]
Related Issue(s)
Fixes #8740
How to test
Release Notes
Documentation