[installer] Disable definitely-gp by default #8740
Assignees
Labels
component: install
Terraform installation scripts, helm charts, installer images
team: delivery
Issue belongs to the self-hosted team
Milestone
Comments
corneliusludmann
added
component: install
corneliusludmann
moved this to 🧊Backlog
in 🚚 Security, Infrastructure, and Delivery Team (SID)
corneliusludmann
moved this from 🧊Backlog
to 🤝Proposed
in 🚚 Security, Infrastructure, and Delivery Team (SID)
Pothulapati
moved this from 🤝Proposed
to ⚒In Progress
in 🚚 Security, Infrastructure, and Delivery Team (SID)
Pothulapati
added a commit
that referenced
this issue
Apr 4, 2022
Fixes #8740 `definitely-gp` is being deprecated soon, and hence it is important to be disabled by default. Once it is fully deprecated, even this option has to be removed. For now, The following changes have been made: - Update the `definitelyGpDisabled` option to be true, Thus disabling it by default - Update the airgap docs to remove a mention of this Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
added a commit
that referenced
this issue
Apr 4, 2022
Fixes #8740 `definitely-gp` is being deprecated soon, and hence it is important to be disabled by default. Once it is fully deprecated, even this option has to be removed. For now, The following changes have been made: - Update the `definitelyGpDisabled` option to be true, Thus disabling it by default - Update the airgap docs to remove a mention of this Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
added a commit
that referenced
this issue
Apr 5, 2022
Fixes #8740 `definitely-gp` is being deprecated soon, and hence it is important to be disabled by default. Once it is fully deprecated, even this option has to be removed. For now, The following changes have been made: - Update the `definitelyGpDisabled` option to be true, Thus disabling it by default - Update the airgap docs to remove a mention of this Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
added a commit
that referenced
this issue
Apr 8, 2022
Fixes #8740 `definitely-gp` is being deprecated soon, and hence it is important to be disabled by default. Once it is fully deprecated, even this option has to be removed. For now, The following changes have been made: - Update the `definitelyGpDisabled` option to be true, Thus disabling it by default both in the `installer` and `chart`. - Update the airgap docs to remove a mention of this. Signed-off-by: Tarun Pothulapati <[email protected]>
roboquat
pushed a commit
that referenced
this issue
Apr 13, 2022
Fixes #8740 `definitely-gp` is being deprecated soon, and hence it is important to be disabled by default. Once it is fully deprecated, even this option has to be removed. For now, The following changes have been made: - Update the `definitelyGpDisabled` option to be true, Thus disabling it by default both in the `installer` and `chart`. - Update the airgap docs to remove a mention of this. Signed-off-by: Tarun Pothulapati <[email protected]>
Repository owner
moved this from ⚒In Progress
to ✨Done
in 🚚 Security, Infrastructure, and Delivery Team (SID)
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The installer has a config value
definitelyGpDisabledthat is currentlyfalseby default. Since we deprecatedefinitely-gpsoon, we should set it totrueby default.Things to consider:
air-gap.mdfalsefor preview envs and SaaS installationsThe text was updated successfully, but these errors were encountered: