Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer] Disable definitely-gp by default #9094

Merged
merged 1 commit into from
Apr 13, 2022
Merged

[installer] Disable definitely-gp by default #9094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ components:
minAgePrebuildDays: 7
contentRetentionPeriodDays: 21
contentChunkLimit: 1000
definitelyGpDisabled: "false"
definitelyGpDisabled: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ok changing the type from a string to a boolean?

Copy link
Contributor Author

@Pothulapati Pothulapati Apr 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, can confirm that we aren't using it anywhere to toggle something, but just passing it down into the server-configmap, and follow the same pattern there like other boolean values (soemthing like enableLocalApp)

enableLocalApp: false
disableDynamicAuthProviderLogin: false
maxEnvvarPerUserCount: 4048
Expand Down
3 changes: 1 addition & 2 deletions install/installer/docs/air-gap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,10 @@ done

## Install Gitpod in Air-Gap Mode

To install Gitpod in an air-gap network, you need to configure the repository of the images needed by Gitpod (see previous step) and disable the `definitely-gp` feature. Add this to your Gitpod config:
To install Gitpod in an air-gap network, you need to configure the repository of the images needed by Gitpod (see previous step). Add this to your Gitpod config:

```yaml
repository: your-registry.example.com
disableDefinitelyGp: true
```

That's it. Run the following commands as usual and Gitpod fetches the images from your registry and does not need internet access to operate:
Expand Down
2 changes: 1 addition & 1 deletion install/installer/example-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ containerRegistry:
inCluster: true
database:
inCluster: true
disableDefinitelyGp: false
disableDefinitelyGp: true
domain: ""
kind: Full
metadata:
Expand Down
2 changes: 1 addition & 1 deletion install/installer/pkg/config/v1/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ func (v version) Defaults(in interface{}) error {
cfg.Workspace.Runtime.ContainerDSocket = "/run/containerd/containerd.sock"
cfg.Workspace.Runtime.ContainerDRuntimeDir = "/var/lib/containerd/io.containerd.runtime.v2.task/k8s.io"
cfg.OpenVSX.URL = "https://open-vsx.org"
cfg.DisableDefinitelyGP = false
cfg.DisableDefinitelyGP = true

return nil
}
Expand Down